subsurface/desktop-widgets/tab-widgets/TabDiveExtraInfo.h

#ifndef TAB_DIVE_EXTRA_INFO_H
#define TAB_DIVE_EXTRA_INFO_H

#include "TabBase.h"

namespace Ui {
	class TabDiveExtraInfo;
};

class ExtraDataModel;

class TabDiveExtraInfo : public TabBase {
	Q_OBJECT
public:
	TabDiveExtraInfo(QWidget *parent = 0);
	~TabDiveExtraInfo();
	void updateData() override;
	void clear() override;
private:
	Ui::TabDiveExtraInfo *ui;
	ExtraDataModel *extraDataModel;
};

#endif
Break down MainTab into smaller classes Maintab is one of our most complex classes, and it's something I'm not actually proud of. But it currently works and the idea of splitting it was in my head for quite a while. This is the third or fourth tentative of splitting it, and this time I let the most complex part of it untouched, the Notes and Equipment tab are way too complex to untangle right now on my limited time. A new class 'TabBase' should be used for any new tab that we may create, and added on the MainTab (see the new lines on the MainTab constructor). Also, Extra Info, Information, Photos and Statistics where ported to this new way helping reduce the number of lines and functions on the MainTab quite a bit. Overall this is a step in the right direction for the future. Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org> Signed-off-by: Dirk Hohndel <dirk@hohndel.org> 2017-04-04 17:21:30 +00:00			`#ifndef TAB_DIVE_EXTRA_INFO_H`
			`#define TAB_DIVE_EXTRA_INFO_H`

			`#include "TabBase.h"`

			`namespace Ui {`
			`class TabDiveExtraInfo;`
			`};`

			`class ExtraDataModel;`

			`class TabDiveExtraInfo : public TabBase {`
			`Q_OBJECT`
			`public:`
Aparently, remove a QXB warning. Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org> Signed-off-by: Dirk Hohndel <dirk@hohndel.org> 2017-04-04 18:01:47 +00:00			`TabDiveExtraInfo(QWidget *parent = 0);`
Break down MainTab into smaller classes Maintab is one of our most complex classes, and it's something I'm not actually proud of. But it currently works and the idea of splitting it was in my head for quite a while. This is the third or fourth tentative of splitting it, and this time I let the most complex part of it untouched, the Notes and Equipment tab are way too complex to untangle right now on my limited time. A new class 'TabBase' should be used for any new tab that we may create, and added on the MainTab (see the new lines on the MainTab constructor). Also, Extra Info, Information, Photos and Statistics where ported to this new way helping reduce the number of lines and functions on the MainTab quite a bit. Overall this is a step in the right direction for the future. Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org> Signed-off-by: Dirk Hohndel <dirk@hohndel.org> 2017-04-04 17:21:30 +00:00			`~TabDiveExtraInfo();`
			`void updateData() override;`
			`void clear() override;`
			`private:`
			`Ui::TabDiveExtraInfo *ui;`
			`ExtraDataModel *extraDataModel;`
			`};`

			`#endif`