2017-04-27 18:25:32 +00:00
|
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
2015-05-28 19:23:49 +00:00
|
|
|
|
#include "cylindermodel.h"
|
2015-05-28 19:39:15 +00:00
|
|
|
|
#include "tankinfomodel.h"
|
2015-05-28 19:23:49 +00:00
|
|
|
|
#include "models.h"
|
2018-06-03 20:15:19 +00:00
|
|
|
|
#include "core/qthelper.h"
|
2019-07-15 21:44:39 +00:00
|
|
|
|
#include "core/divelist.h" // for mark_divelist_changed()
|
2016-04-05 05:02:03 +00:00
|
|
|
|
#include "core/color.h"
|
|
|
|
|
#include "qt-models/diveplannermodel.h"
|
|
|
|
|
#include "core/gettextfromc.h"
|
2019-02-23 21:09:34 +00:00
|
|
|
|
#include "core/subsurface-qt/DiveListNotifier.h"
|
2015-05-28 19:23:49 +00:00
|
|
|
|
|
2016-03-07 06:43:20 +00:00
|
|
|
|
CylindersModel::CylindersModel(QObject *parent) :
|
|
|
|
|
CleanerTableModel(parent),
|
|
|
|
|
changed(false),
|
2015-05-28 19:23:49 +00:00
|
|
|
|
rows(0)
|
|
|
|
|
{
|
2016-07-06 12:40:32 +00:00
|
|
|
|
// enum {REMOVE, TYPE, SIZE, WORKINGPRESS, START, END, O2, HE, DEPTH, MOD, MND, USE};
|
2015-05-28 19:23:49 +00:00
|
|
|
|
setHeaderDataStrings(QStringList() << "" << tr("Type") << tr("Size") << tr("Work press.") << tr("Start press.") << tr("End press.") << tr("O₂%") << tr("He%")
|
2016-07-19 09:01:06 +00:00
|
|
|
|
<< tr("Deco switch at") <<tr("Bot. MOD") <<tr("MND") << tr("Use"));
|
2015-05-28 19:23:49 +00:00
|
|
|
|
|
2019-02-23 21:09:34 +00:00
|
|
|
|
connect(&diveListNotifier, &DiveListNotifier::cylindersReset, this, &CylindersModel::cylindersReset);
|
2015-05-28 19:23:49 +00:00
|
|
|
|
}
|
|
|
|
|
|
2017-02-26 12:34:17 +00:00
|
|
|
|
QVariant CylindersModel::headerData(int section, Qt::Orientation orientation, int role) const
|
|
|
|
|
{
|
2017-03-11 06:42:20 +00:00
|
|
|
|
if (role == Qt::DisplayRole && orientation == Qt::Horizontal && in_planner() && section == WORKINGPRESS)
|
2017-02-26 12:34:17 +00:00
|
|
|
|
return tr("Start press.");
|
|
|
|
|
else
|
|
|
|
|
return CleanerTableModel::headerData(section, orientation, role);
|
|
|
|
|
}
|
|
|
|
|
|
2015-05-28 19:23:49 +00:00
|
|
|
|
CylindersModel *CylindersModel::instance()
|
|
|
|
|
{
|
2017-12-20 19:00:26 +00:00
|
|
|
|
static CylindersModel self;
|
|
|
|
|
return &self;
|
2015-05-28 19:23:49 +00:00
|
|
|
|
}
|
|
|
|
|
|
2019-08-04 14:28:16 +00:00
|
|
|
|
static QString get_cylinder_string(const cylinder_t *cyl)
|
Don't use "get_volume_string()" for cylinder size string
We had two totally different usage cases for "get_volume_string()": one
that did the obvious "show this volume as a string", and one that tried
to show a cylinder size.
The function used a magic third argument (the working pressure of the
cylinder) to distinguish between the two cases, but it still got it
wrong.
A metric cylinder doesn't necessarily have a working pressure at all,
and the size is a wet size in liters. We'd pass in zero as the working
pressure, and if the volume units were set to cubic feet, the logic in
"get_volume_string()" would happily convert the metric wet size into the
wet size in cubic feet.
But that's completely wrong. An imperial cylinder size simply isn't a
wet size. If you don't have a working pressure, you cannot convert the
cylinder size to cubic feet. End of story.
So instead of having "get_volume_string()" have magical behavior
depending on working pressure, and getting it wrong anyway, just make
get_volume_string do a pure volume conversion, and create a whole new
function for showing the size of a cylinder.
Now, if the cylinder doesn't have a working pressure, we just show the
metric size, even if the user had asked for cubic feet.
[Dirk Hohndel: added call to translation functions for the units]
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-02-24 22:42:56 +00:00
|
|
|
|
{
|
|
|
|
|
QString unit;
|
|
|
|
|
int decimals;
|
|
|
|
|
unsigned int ml = cyl->type.size.mliter;
|
|
|
|
|
pressure_t wp = cyl->type.workingpressure;
|
|
|
|
|
double value;
|
|
|
|
|
|
|
|
|
|
// We cannot use "get_volume_units()", because even when
|
|
|
|
|
// using imperial units we may need to show the size in
|
|
|
|
|
// liters: if we don't have a working pressure, we cannot
|
|
|
|
|
// convert the cylinder size to cuft.
|
|
|
|
|
if (wp.mbar && prefs.units.volume == units::CUFT) {
|
|
|
|
|
value = ml_to_cuft(ml) * bar_to_atm(wp.mbar / 1000.0);
|
|
|
|
|
decimals = (value > 20.0) ? 0 : (value > 2.0) ? 1 : 2;
|
2017-01-16 11:30:57 +00:00
|
|
|
|
unit = CylindersModel::tr("cuft");
|
Don't use "get_volume_string()" for cylinder size string
We had two totally different usage cases for "get_volume_string()": one
that did the obvious "show this volume as a string", and one that tried
to show a cylinder size.
The function used a magic third argument (the working pressure of the
cylinder) to distinguish between the two cases, but it still got it
wrong.
A metric cylinder doesn't necessarily have a working pressure at all,
and the size is a wet size in liters. We'd pass in zero as the working
pressure, and if the volume units were set to cubic feet, the logic in
"get_volume_string()" would happily convert the metric wet size into the
wet size in cubic feet.
But that's completely wrong. An imperial cylinder size simply isn't a
wet size. If you don't have a working pressure, you cannot convert the
cylinder size to cubic feet. End of story.
So instead of having "get_volume_string()" have magical behavior
depending on working pressure, and getting it wrong anyway, just make
get_volume_string do a pure volume conversion, and create a whole new
function for showing the size of a cylinder.
Now, if the cylinder doesn't have a working pressure, we just show the
metric size, even if the user had asked for cubic feet.
[Dirk Hohndel: added call to translation functions for the units]
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-02-24 22:42:56 +00:00
|
|
|
|
} else {
|
|
|
|
|
value = ml / 1000.0;
|
|
|
|
|
decimals = 1;
|
|
|
|
|
unit = CylindersModel::tr("ℓ");
|
|
|
|
|
}
|
|
|
|
|
|
2018-02-19 20:55:18 +00:00
|
|
|
|
return QString("%L1").arg(value, 0, 'f', decimals) + unit;
|
Don't use "get_volume_string()" for cylinder size string
We had two totally different usage cases for "get_volume_string()": one
that did the obvious "show this volume as a string", and one that tried
to show a cylinder size.
The function used a magic third argument (the working pressure of the
cylinder) to distinguish between the two cases, but it still got it
wrong.
A metric cylinder doesn't necessarily have a working pressure at all,
and the size is a wet size in liters. We'd pass in zero as the working
pressure, and if the volume units were set to cubic feet, the logic in
"get_volume_string()" would happily convert the metric wet size into the
wet size in cubic feet.
But that's completely wrong. An imperial cylinder size simply isn't a
wet size. If you don't have a working pressure, you cannot convert the
cylinder size to cubic feet. End of story.
So instead of having "get_volume_string()" have magical behavior
depending on working pressure, and getting it wrong anyway, just make
get_volume_string do a pure volume conversion, and create a whole new
function for showing the size of a cylinder.
Now, if the cylinder doesn't have a working pressure, we just show the
metric size, even if the user had asked for cubic feet.
[Dirk Hohndel: added call to translation functions for the units]
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-02-24 22:42:56 +00:00
|
|
|
|
}
|
|
|
|
|
|
2017-01-11 17:22:41 +00:00
|
|
|
|
static QString gas_volume_string(int ml, const char *tail)
|
|
|
|
|
{
|
|
|
|
|
double vol;
|
|
|
|
|
const char *unit;
|
|
|
|
|
int decimals;
|
|
|
|
|
|
|
|
|
|
vol = get_volume_units(ml, NULL, &unit);
|
|
|
|
|
decimals = (vol > 20.0) ? 0 : (vol > 2.0) ? 1 : 2;
|
|
|
|
|
|
2018-02-19 20:55:18 +00:00
|
|
|
|
return QString("%L1 %2 %3").arg(vol, 0, 'f', decimals).arg(unit).arg(tail);
|
2017-01-11 17:22:41 +00:00
|
|
|
|
}
|
|
|
|
|
|
2019-08-04 14:28:16 +00:00
|
|
|
|
static QVariant gas_wp_tooltip(const cylinder_t *cyl);
|
Tweak cylinder equipment tooltips
While playing around with the current subsurface, I realized that while we
give the gas volume and Z factor for the beginning/end pressures in the
newly added tooltips, there is no way to actually see that same
information for the working pressure.
So if you have filled in cylinder type information, but don't have any
actual gas usage information, there will be no cylinder tooltips at all.
But you might still want to know what the actual volume for a particular
cylinder is, and what the Z value for that working pressure is.
So this tweaks the tool-tips a bit.
When mousing over the pressure fields (ie "working pressure", "start" and
"end"), it now always gives the cylinder gas volume and Z factor for that
pressure, so for example on an AL72 that has a working pressure of 3000
psi and that contains air the tooltip will say:
69 cuft, Z=1.040
when you mouse over the working pressure field (that's obviously with
imperial units, in metric you'll see liters of gas).
When mousing over the type/size field, it gives the used gas amounts, ie
something like this:
37 cuft (82 cuft -> 45 cuft)
but if the cylinder doesn't have starting/ending pressures (and thus no
used gas information), this patch will make subsurface show the working
pressure data instead, so that you at least get something.
This all seems more useful than what my first version gave.
NOTE! This makes commit adaeb506b7a1 ("Show both the nominal and "real"
size for an imperial cylinder") kind of pointless. You now see the real
size in the tooltip when you mouse over the size, and now it actually
works both for imperial and metric people, so the tooltip is in many ways
the better model.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-01-16 00:07:35 +00:00
|
|
|
|
|
2019-08-04 14:28:16 +00:00
|
|
|
|
static QVariant gas_usage_tooltip(const cylinder_t *cyl)
|
2017-01-11 17:22:41 +00:00
|
|
|
|
{
|
|
|
|
|
pressure_t startp = cyl->start.mbar ? cyl->start : cyl->sample_start;
|
|
|
|
|
pressure_t endp = cyl->end.mbar ? cyl->end : cyl->sample_end;
|
|
|
|
|
|
|
|
|
|
int start, end, used;
|
|
|
|
|
|
|
|
|
|
start = gas_volume(cyl, startp);
|
|
|
|
|
end = gas_volume(cyl, endp);
|
|
|
|
|
used = (end && start > end) ? start - end : 0;
|
|
|
|
|
|
|
|
|
|
if (!used)
|
Tweak cylinder equipment tooltips
While playing around with the current subsurface, I realized that while we
give the gas volume and Z factor for the beginning/end pressures in the
newly added tooltips, there is no way to actually see that same
information for the working pressure.
So if you have filled in cylinder type information, but don't have any
actual gas usage information, there will be no cylinder tooltips at all.
But you might still want to know what the actual volume for a particular
cylinder is, and what the Z value for that working pressure is.
So this tweaks the tool-tips a bit.
When mousing over the pressure fields (ie "working pressure", "start" and
"end"), it now always gives the cylinder gas volume and Z factor for that
pressure, so for example on an AL72 that has a working pressure of 3000
psi and that contains air the tooltip will say:
69 cuft, Z=1.040
when you mouse over the working pressure field (that's obviously with
imperial units, in metric you'll see liters of gas).
When mousing over the type/size field, it gives the used gas amounts, ie
something like this:
37 cuft (82 cuft -> 45 cuft)
but if the cylinder doesn't have starting/ending pressures (and thus no
used gas information), this patch will make subsurface show the working
pressure data instead, so that you at least get something.
This all seems more useful than what my first version gave.
NOTE! This makes commit adaeb506b7a1 ("Show both the nominal and "real"
size for an imperial cylinder") kind of pointless. You now see the real
size in the tooltip when you mouse over the size, and now it actually
works both for imperial and metric people, so the tooltip is in many ways
the better model.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-01-16 00:07:35 +00:00
|
|
|
|
return gas_wp_tooltip(cyl);
|
2017-01-11 17:22:41 +00:00
|
|
|
|
|
|
|
|
|
return gas_volume_string(used, "(") +
|
|
|
|
|
gas_volume_string(start, " -> ") +
|
|
|
|
|
gas_volume_string(end, ")");
|
|
|
|
|
}
|
|
|
|
|
|
2019-08-04 14:28:16 +00:00
|
|
|
|
static QVariant gas_volume_tooltip(const cylinder_t *cyl, pressure_t p)
|
2017-01-11 17:22:41 +00:00
|
|
|
|
{
|
|
|
|
|
int vol = gas_volume(cyl, p);
|
|
|
|
|
double Z;
|
|
|
|
|
|
|
|
|
|
if (!vol)
|
|
|
|
|
return QVariant();
|
|
|
|
|
|
2018-08-16 17:10:10 +00:00
|
|
|
|
Z = gas_compressibility_factor(cyl->gasmix, p.mbar / 1000.0);
|
2017-01-11 17:22:41 +00:00
|
|
|
|
return gas_volume_string(vol, "(Z=") + QString("%1)").arg(Z, 0, 'f', 3);
|
|
|
|
|
}
|
|
|
|
|
|
2019-08-04 14:28:16 +00:00
|
|
|
|
static QVariant gas_wp_tooltip(const cylinder_t *cyl)
|
Tweak cylinder equipment tooltips
While playing around with the current subsurface, I realized that while we
give the gas volume and Z factor for the beginning/end pressures in the
newly added tooltips, there is no way to actually see that same
information for the working pressure.
So if you have filled in cylinder type information, but don't have any
actual gas usage information, there will be no cylinder tooltips at all.
But you might still want to know what the actual volume for a particular
cylinder is, and what the Z value for that working pressure is.
So this tweaks the tool-tips a bit.
When mousing over the pressure fields (ie "working pressure", "start" and
"end"), it now always gives the cylinder gas volume and Z factor for that
pressure, so for example on an AL72 that has a working pressure of 3000
psi and that contains air the tooltip will say:
69 cuft, Z=1.040
when you mouse over the working pressure field (that's obviously with
imperial units, in metric you'll see liters of gas).
When mousing over the type/size field, it gives the used gas amounts, ie
something like this:
37 cuft (82 cuft -> 45 cuft)
but if the cylinder doesn't have starting/ending pressures (and thus no
used gas information), this patch will make subsurface show the working
pressure data instead, so that you at least get something.
This all seems more useful than what my first version gave.
NOTE! This makes commit adaeb506b7a1 ("Show both the nominal and "real"
size for an imperial cylinder") kind of pointless. You now see the real
size in the tooltip when you mouse over the size, and now it actually
works both for imperial and metric people, so the tooltip is in many ways
the better model.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-01-16 00:07:35 +00:00
|
|
|
|
{
|
|
|
|
|
return gas_volume_tooltip(cyl, cyl->type.workingpressure);
|
|
|
|
|
}
|
|
|
|
|
|
2019-08-04 14:28:16 +00:00
|
|
|
|
static QVariant gas_start_tooltip(const cylinder_t *cyl)
|
2017-01-11 17:22:41 +00:00
|
|
|
|
{
|
|
|
|
|
return gas_volume_tooltip(cyl, cyl->start.mbar ? cyl->start : cyl->sample_start);
|
|
|
|
|
}
|
|
|
|
|
|
2019-08-04 14:28:16 +00:00
|
|
|
|
static QVariant gas_end_tooltip(const cylinder_t *cyl)
|
2017-01-11 17:22:41 +00:00
|
|
|
|
{
|
|
|
|
|
return gas_volume_tooltip(cyl, cyl->end.mbar ? cyl->end : cyl->sample_end);
|
|
|
|
|
}
|
Don't use "get_volume_string()" for cylinder size string
We had two totally different usage cases for "get_volume_string()": one
that did the obvious "show this volume as a string", and one that tried
to show a cylinder size.
The function used a magic third argument (the working pressure of the
cylinder) to distinguish between the two cases, but it still got it
wrong.
A metric cylinder doesn't necessarily have a working pressure at all,
and the size is a wet size in liters. We'd pass in zero as the working
pressure, and if the volume units were set to cubic feet, the logic in
"get_volume_string()" would happily convert the metric wet size into the
wet size in cubic feet.
But that's completely wrong. An imperial cylinder size simply isn't a
wet size. If you don't have a working pressure, you cannot convert the
cylinder size to cubic feet. End of story.
So instead of having "get_volume_string()" have magical behavior
depending on working pressure, and getting it wrong anyway, just make
get_volume_string do a pure volume conversion, and create a whole new
function for showing the size of a cylinder.
Now, if the cylinder doesn't have a working pressure, we just show the
metric size, even if the user had asked for cubic feet.
[Dirk Hohndel: added call to translation functions for the units]
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-02-24 22:42:56 +00:00
|
|
|
|
|
2015-05-28 19:23:49 +00:00
|
|
|
|
static QVariant percent_string(fraction_t fraction)
|
|
|
|
|
{
|
|
|
|
|
int permille = fraction.permille;
|
|
|
|
|
|
|
|
|
|
if (!permille)
|
|
|
|
|
return QVariant();
|
2018-02-19 20:55:18 +00:00
|
|
|
|
return QString("%L1%").arg(permille / 10.0, 0, 'f', 1);
|
2015-05-28 19:23:49 +00:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
QVariant CylindersModel::data(const QModelIndex &index, int role) const
|
|
|
|
|
{
|
2019-08-04 16:44:57 +00:00
|
|
|
|
if (!index.isValid() || index.row() >= rows)
|
2019-06-08 06:49:12 +00:00
|
|
|
|
return QVariant();
|
2017-10-20 21:25:18 +00:00
|
|
|
|
|
2019-08-04 20:13:49 +00:00
|
|
|
|
const cylinder_t *cyl = get_cylinder(&displayed_dive, index.row());
|
2017-10-20 21:25:18 +00:00
|
|
|
|
|
2015-05-28 19:23:49 +00:00
|
|
|
|
switch (role) {
|
|
|
|
|
case Qt::BackgroundRole: {
|
|
|
|
|
switch (index.column()) {
|
|
|
|
|
// mark the cylinder start / end pressure in red if the values
|
|
|
|
|
// seem implausible
|
|
|
|
|
case START:
|
|
|
|
|
case END:
|
2017-03-20 21:10:42 +00:00
|
|
|
|
pressure_t startp, endp;
|
|
|
|
|
startp = cyl->start.mbar ? cyl->start : cyl->sample_start;
|
|
|
|
|
endp = cyl->end.mbar ? cyl->end : cyl->sample_end;
|
|
|
|
|
if ((startp.mbar && !endp.mbar) ||
|
|
|
|
|
(endp.mbar && startp.mbar <= endp.mbar))
|
2019-06-08 06:49:12 +00:00
|
|
|
|
return REDORANGE1_HIGH_TRANS;
|
2015-05-28 19:23:49 +00:00
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
case Qt::FontRole: {
|
|
|
|
|
QFont font = defaultModelFont();
|
|
|
|
|
switch (index.column()) {
|
2017-03-20 21:10:42 +00:00
|
|
|
|
// if we don't have manually set pressure data use italic font
|
2015-05-28 19:23:49 +00:00
|
|
|
|
case START:
|
|
|
|
|
font.setItalic(!cyl->start.mbar);
|
|
|
|
|
break;
|
|
|
|
|
case END:
|
2017-03-20 21:10:42 +00:00
|
|
|
|
font.setItalic(!cyl->end.mbar);
|
2015-05-28 19:23:49 +00:00
|
|
|
|
break;
|
|
|
|
|
}
|
2019-06-08 06:49:12 +00:00
|
|
|
|
return font;
|
2015-05-28 19:23:49 +00:00
|
|
|
|
}
|
|
|
|
|
case Qt::TextAlignmentRole:
|
2019-06-08 06:49:12 +00:00
|
|
|
|
return Qt::AlignCenter;
|
2015-05-28 19:23:49 +00:00
|
|
|
|
case Qt::DisplayRole:
|
|
|
|
|
case Qt::EditRole:
|
|
|
|
|
switch (index.column()) {
|
|
|
|
|
case TYPE:
|
2019-06-08 06:49:12 +00:00
|
|
|
|
return QString(cyl->type.description);
|
2015-05-28 19:23:49 +00:00
|
|
|
|
case SIZE:
|
|
|
|
|
if (cyl->type.size.mliter)
|
2019-06-08 06:49:12 +00:00
|
|
|
|
return get_cylinder_string(cyl);
|
2015-05-28 19:23:49 +00:00
|
|
|
|
break;
|
|
|
|
|
case WORKINGPRESS:
|
|
|
|
|
if (cyl->type.workingpressure.mbar)
|
2019-06-08 06:49:12 +00:00
|
|
|
|
return get_pressure_string(cyl->type.workingpressure, true);
|
2015-05-28 19:23:49 +00:00
|
|
|
|
break;
|
|
|
|
|
case START:
|
|
|
|
|
if (cyl->start.mbar)
|
2019-06-08 06:49:12 +00:00
|
|
|
|
return get_pressure_string(cyl->start, true);
|
2015-05-28 19:23:49 +00:00
|
|
|
|
else if (cyl->sample_start.mbar)
|
2019-06-08 06:49:12 +00:00
|
|
|
|
return get_pressure_string(cyl->sample_start, true);
|
2015-05-28 19:23:49 +00:00
|
|
|
|
break;
|
|
|
|
|
case END:
|
|
|
|
|
if (cyl->end.mbar)
|
2019-06-08 06:49:12 +00:00
|
|
|
|
return get_pressure_string(cyl->end, true);
|
2015-05-28 19:23:49 +00:00
|
|
|
|
else if (cyl->sample_end.mbar)
|
2019-06-08 06:49:12 +00:00
|
|
|
|
return get_pressure_string(cyl->sample_end, true);
|
2015-05-28 19:23:49 +00:00
|
|
|
|
break;
|
|
|
|
|
case O2:
|
2019-06-08 06:49:12 +00:00
|
|
|
|
return percent_string(cyl->gasmix.o2);
|
2015-05-28 19:23:49 +00:00
|
|
|
|
case HE:
|
2019-06-08 06:49:12 +00:00
|
|
|
|
return percent_string(cyl->gasmix.he);
|
2015-05-28 19:23:49 +00:00
|
|
|
|
case DEPTH:
|
2019-06-08 06:49:12 +00:00
|
|
|
|
return get_depth_string(cyl->depth, true);
|
2016-07-06 12:40:32 +00:00
|
|
|
|
case MOD:
|
2016-07-06 12:40:35 +00:00
|
|
|
|
if (cyl->bestmix_o2) {
|
2019-06-08 06:49:12 +00:00
|
|
|
|
return QStringLiteral("*");
|
2016-07-06 12:40:35 +00:00
|
|
|
|
} else {
|
|
|
|
|
pressure_t modpO2;
|
|
|
|
|
modpO2.mbar = prefs.bottompo2;
|
2019-06-08 06:49:12 +00:00
|
|
|
|
return get_depth_string(gas_mod(cyl->gasmix, modpO2, &displayed_dive, M_OR_FT(1,1)), true);
|
2016-07-06 12:40:35 +00:00
|
|
|
|
}
|
2016-07-06 12:40:32 +00:00
|
|
|
|
case MND:
|
2016-07-06 12:40:35 +00:00
|
|
|
|
if (cyl->bestmix_he)
|
2019-06-08 06:49:12 +00:00
|
|
|
|
return QStringLiteral("*");
|
2016-07-06 12:40:35 +00:00
|
|
|
|
else
|
2019-06-08 06:49:12 +00:00
|
|
|
|
return get_depth_string(gas_mnd(cyl->gasmix, prefs.bestmixend, &displayed_dive, M_OR_FT(1,1)), true);
|
2016-07-06 12:40:32 +00:00
|
|
|
|
break;
|
2015-05-28 19:23:49 +00:00
|
|
|
|
case USE:
|
2019-06-08 06:49:12 +00:00
|
|
|
|
return gettextFromC::tr(cylinderuse_text[cyl->cylinder_use]);
|
2015-05-28 19:23:49 +00:00
|
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
case Qt::DecorationRole:
|
|
|
|
|
case Qt::SizeHintRole:
|
2015-10-21 22:17:05 +00:00
|
|
|
|
if (index.column() == REMOVE) {
|
2017-10-20 11:30:04 +00:00
|
|
|
|
if ((in_planner() && DivePlannerPointsModel::instance()->tankInUse(index.row())) ||
|
2017-11-29 09:16:00 +00:00
|
|
|
|
(!in_planner() && is_cylinder_prot(&displayed_dive, index.row()))) {
|
2019-06-08 06:49:12 +00:00
|
|
|
|
return trashForbiddenIcon();
|
2017-03-11 09:39:48 +00:00
|
|
|
|
}
|
2019-06-08 06:49:12 +00:00
|
|
|
|
return trashIcon();
|
2015-10-21 22:17:05 +00:00
|
|
|
|
}
|
2015-05-28 19:23:49 +00:00
|
|
|
|
break;
|
|
|
|
|
case Qt::ToolTipRole:
|
2016-08-02 01:02:14 +00:00
|
|
|
|
switch (index.column()) {
|
|
|
|
|
case REMOVE:
|
2017-10-20 11:30:04 +00:00
|
|
|
|
if ((in_planner() && DivePlannerPointsModel::instance()->tankInUse(index.row())) ||
|
2017-11-29 09:16:00 +00:00
|
|
|
|
(!in_planner() && is_cylinder_prot(&displayed_dive, index.row()))) {
|
2019-06-08 06:49:12 +00:00
|
|
|
|
return tr("This gas is in use. Only cylinders that are not used in the dive can be removed.");
|
2017-03-11 09:39:48 +00:00
|
|
|
|
}
|
2019-06-08 06:49:12 +00:00
|
|
|
|
return tr("Clicking here will remove this cylinder.");
|
Tweak cylinder equipment tooltips
While playing around with the current subsurface, I realized that while we
give the gas volume and Z factor for the beginning/end pressures in the
newly added tooltips, there is no way to actually see that same
information for the working pressure.
So if you have filled in cylinder type information, but don't have any
actual gas usage information, there will be no cylinder tooltips at all.
But you might still want to know what the actual volume for a particular
cylinder is, and what the Z value for that working pressure is.
So this tweaks the tool-tips a bit.
When mousing over the pressure fields (ie "working pressure", "start" and
"end"), it now always gives the cylinder gas volume and Z factor for that
pressure, so for example on an AL72 that has a working pressure of 3000
psi and that contains air the tooltip will say:
69 cuft, Z=1.040
when you mouse over the working pressure field (that's obviously with
imperial units, in metric you'll see liters of gas).
When mousing over the type/size field, it gives the used gas amounts, ie
something like this:
37 cuft (82 cuft -> 45 cuft)
but if the cylinder doesn't have starting/ending pressures (and thus no
used gas information), this patch will make subsurface show the working
pressure data instead, so that you at least get something.
This all seems more useful than what my first version gave.
NOTE! This makes commit adaeb506b7a1 ("Show both the nominal and "real"
size for an imperial cylinder") kind of pointless. You now see the real
size in the tooltip when you mouse over the size, and now it actually
works both for imperial and metric people, so the tooltip is in many ways
the better model.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-01-16 00:07:35 +00:00
|
|
|
|
case TYPE:
|
2017-01-11 17:22:41 +00:00
|
|
|
|
case SIZE:
|
|
|
|
|
return gas_usage_tooltip(cyl);
|
Tweak cylinder equipment tooltips
While playing around with the current subsurface, I realized that while we
give the gas volume and Z factor for the beginning/end pressures in the
newly added tooltips, there is no way to actually see that same
information for the working pressure.
So if you have filled in cylinder type information, but don't have any
actual gas usage information, there will be no cylinder tooltips at all.
But you might still want to know what the actual volume for a particular
cylinder is, and what the Z value for that working pressure is.
So this tweaks the tool-tips a bit.
When mousing over the pressure fields (ie "working pressure", "start" and
"end"), it now always gives the cylinder gas volume and Z factor for that
pressure, so for example on an AL72 that has a working pressure of 3000
psi and that contains air the tooltip will say:
69 cuft, Z=1.040
when you mouse over the working pressure field (that's obviously with
imperial units, in metric you'll see liters of gas).
When mousing over the type/size field, it gives the used gas amounts, ie
something like this:
37 cuft (82 cuft -> 45 cuft)
but if the cylinder doesn't have starting/ending pressures (and thus no
used gas information), this patch will make subsurface show the working
pressure data instead, so that you at least get something.
This all seems more useful than what my first version gave.
NOTE! This makes commit adaeb506b7a1 ("Show both the nominal and "real"
size for an imperial cylinder") kind of pointless. You now see the real
size in the tooltip when you mouse over the size, and now it actually
works both for imperial and metric people, so the tooltip is in many ways
the better model.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-01-16 00:07:35 +00:00
|
|
|
|
case WORKINGPRESS:
|
|
|
|
|
return gas_wp_tooltip(cyl);
|
2017-01-11 17:22:41 +00:00
|
|
|
|
case START:
|
|
|
|
|
return gas_start_tooltip(cyl);
|
|
|
|
|
case END:
|
|
|
|
|
return gas_end_tooltip(cyl);
|
2016-08-02 01:02:14 +00:00
|
|
|
|
case DEPTH:
|
2019-06-08 06:49:12 +00:00
|
|
|
|
return tr("Switch depth for deco gas. Calculated using Deco pO₂ preference, unless set manually.");
|
2016-08-02 01:02:14 +00:00
|
|
|
|
case MOD:
|
2019-06-08 06:49:12 +00:00
|
|
|
|
return tr("Calculated using Bottom pO₂ preference. Setting MOD adjusts O₂%, set to '*' for best O₂% for max. depth.");
|
2016-08-02 01:02:14 +00:00
|
|
|
|
case MND:
|
2019-06-08 06:49:12 +00:00
|
|
|
|
return tr("Calculated using Best Mix END preference. Setting MND adjusts He%, set to '*' for best He% for max. depth.");
|
2016-08-02 01:02:14 +00:00
|
|
|
|
}
|
2015-05-28 19:23:49 +00:00
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
2019-06-08 06:49:12 +00:00
|
|
|
|
return QVariant();
|
2015-05-28 19:23:49 +00:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
cylinder_t *CylindersModel::cylinderAt(const QModelIndex &index)
|
|
|
|
|
{
|
2019-08-04 20:13:49 +00:00
|
|
|
|
return get_cylinder(&displayed_dive, index.row());
|
2015-05-28 19:23:49 +00:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// this is our magic 'pass data in' function that allows the delegate to get
|
|
|
|
|
// the data here without silly unit conversions;
|
|
|
|
|
// so we only implement the two columns we care about
|
|
|
|
|
void CylindersModel::passInData(const QModelIndex &index, const QVariant &value)
|
|
|
|
|
{
|
|
|
|
|
cylinder_t *cyl = cylinderAt(index);
|
|
|
|
|
switch (index.column()) {
|
|
|
|
|
case SIZE:
|
|
|
|
|
if (cyl->type.size.mliter != value.toInt()) {
|
|
|
|
|
cyl->type.size.mliter = value.toInt();
|
|
|
|
|
dataChanged(index, index);
|
|
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
case WORKINGPRESS:
|
|
|
|
|
if (cyl->type.workingpressure.mbar != value.toInt()) {
|
|
|
|
|
cyl->type.workingpressure.mbar = value.toInt();
|
|
|
|
|
dataChanged(index, index);
|
|
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
bool CylindersModel::setData(const QModelIndex &index, const QVariant &value, int role)
|
|
|
|
|
{
|
|
|
|
|
QString vString;
|
|
|
|
|
|
|
|
|
|
cylinder_t *cyl = cylinderAt(index);
|
|
|
|
|
switch (index.column()) {
|
|
|
|
|
case TYPE:
|
|
|
|
|
if (!value.isNull()) {
|
|
|
|
|
QByteArray ba = value.toByteArray();
|
|
|
|
|
const char *text = ba.constData();
|
|
|
|
|
if (!cyl->type.description || strcmp(cyl->type.description, text)) {
|
|
|
|
|
cyl->type.description = strdup(text);
|
|
|
|
|
changed = true;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
case SIZE:
|
|
|
|
|
if (CHANGED()) {
|
|
|
|
|
TankInfoModel *tanks = TankInfoModel::instance();
|
|
|
|
|
QModelIndexList matches = tanks->match(tanks->index(0, 0), Qt::DisplayRole, cyl->type.description);
|
|
|
|
|
|
2018-02-25 12:51:41 +00:00
|
|
|
|
cyl->type.size = string_to_volume(qPrintable(vString), cyl->type.workingpressure);
|
2015-05-28 19:23:49 +00:00
|
|
|
|
mark_divelist_changed(true);
|
|
|
|
|
if (!matches.isEmpty())
|
|
|
|
|
tanks->setData(tanks->index(matches.first().row(), TankInfoModel::ML), cyl->type.size.mliter);
|
|
|
|
|
changed = true;
|
|
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
case WORKINGPRESS:
|
|
|
|
|
if (CHANGED()) {
|
|
|
|
|
TankInfoModel *tanks = TankInfoModel::instance();
|
|
|
|
|
QModelIndexList matches = tanks->match(tanks->index(0, 0), Qt::DisplayRole, cyl->type.description);
|
2018-02-25 12:51:41 +00:00
|
|
|
|
cyl->type.workingpressure = string_to_pressure(qPrintable(vString));
|
2015-05-28 19:23:49 +00:00
|
|
|
|
if (!matches.isEmpty())
|
|
|
|
|
tanks->setData(tanks->index(matches.first().row(), TankInfoModel::BAR), cyl->type.workingpressure.mbar / 1000.0);
|
|
|
|
|
changed = true;
|
|
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
case START:
|
|
|
|
|
if (CHANGED()) {
|
2018-02-25 12:51:41 +00:00
|
|
|
|
cyl->start = string_to_pressure(qPrintable(vString));
|
2015-05-28 19:23:49 +00:00
|
|
|
|
changed = true;
|
|
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
case END:
|
|
|
|
|
if (CHANGED()) {
|
2018-02-25 12:51:41 +00:00
|
|
|
|
//&& (!cyl->start.mbar || string_to_pressure(qPrintable(vString)).mbar <= cyl->start.mbar)) {
|
|
|
|
|
cyl->end = string_to_pressure(qPrintable(vString));
|
2015-05-28 19:23:49 +00:00
|
|
|
|
changed = true;
|
|
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
case O2:
|
|
|
|
|
if (CHANGED()) {
|
2018-02-25 12:51:41 +00:00
|
|
|
|
cyl->gasmix.o2 = string_to_fraction(qPrintable(vString));
|
2016-05-22 01:00:22 +00:00
|
|
|
|
// fO2 + fHe must not be greater than 1
|
2018-08-16 17:10:10 +00:00
|
|
|
|
if (get_o2(cyl->gasmix) + get_he(cyl->gasmix) > 1000)
|
|
|
|
|
cyl->gasmix.he.permille = 1000 - get_o2(cyl->gasmix);
|
2015-05-28 19:23:49 +00:00
|
|
|
|
pressure_t modpO2;
|
|
|
|
|
if (displayed_dive.dc.divemode == PSCR)
|
2018-08-16 17:10:10 +00:00
|
|
|
|
modpO2.mbar = prefs.decopo2 + (1000 - get_o2(cyl->gasmix)) * SURFACE_PRESSURE *
|
2015-05-28 19:23:49 +00:00
|
|
|
|
prefs.o2consumption / prefs.decosac / prefs.pscr_ratio;
|
|
|
|
|
else
|
|
|
|
|
modpO2.mbar = prefs.decopo2;
|
2018-08-16 17:10:10 +00:00
|
|
|
|
cyl->depth = gas_mod(cyl->gasmix, modpO2, &displayed_dive, M_OR_FT(3, 10));
|
2016-07-06 12:40:35 +00:00
|
|
|
|
cyl->bestmix_o2 = false;
|
2015-05-28 19:23:49 +00:00
|
|
|
|
changed = true;
|
|
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
case HE:
|
|
|
|
|
if (CHANGED()) {
|
2018-02-25 12:51:41 +00:00
|
|
|
|
cyl->gasmix.he = string_to_fraction(qPrintable(vString));
|
2016-05-22 01:00:22 +00:00
|
|
|
|
// fO2 + fHe must not be greater than 1
|
2018-08-16 17:10:10 +00:00
|
|
|
|
if (get_o2(cyl->gasmix) + get_he(cyl->gasmix) > 1000)
|
|
|
|
|
cyl->gasmix.o2.permille = 1000 - get_he(cyl->gasmix);
|
2016-07-06 12:40:35 +00:00
|
|
|
|
cyl->bestmix_he = false;
|
2015-05-28 19:23:49 +00:00
|
|
|
|
changed = true;
|
|
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
case DEPTH:
|
|
|
|
|
if (CHANGED()) {
|
2018-02-25 12:51:41 +00:00
|
|
|
|
cyl->depth = string_to_depth(qPrintable(vString));
|
2015-05-28 19:23:49 +00:00
|
|
|
|
changed = true;
|
|
|
|
|
}
|
|
|
|
|
break;
|
2016-07-06 12:40:32 +00:00
|
|
|
|
case MOD:
|
|
|
|
|
if (CHANGED()) {
|
2018-02-25 12:51:41 +00:00
|
|
|
|
if (QString::compare(qPrintable(vString), "*") == 0) {
|
2016-07-06 12:40:35 +00:00
|
|
|
|
cyl->bestmix_o2 = true;
|
2017-03-06 12:27:39 +00:00
|
|
|
|
// Calculate fO2 for max. depth
|
2016-07-06 12:40:35 +00:00
|
|
|
|
cyl->gasmix.o2 = best_o2(displayed_dive.maxdepth, &displayed_dive);
|
|
|
|
|
} else {
|
|
|
|
|
cyl->bestmix_o2 = false;
|
|
|
|
|
// Calculate fO2 for input depth
|
2018-02-25 12:51:41 +00:00
|
|
|
|
cyl->gasmix.o2 = best_o2(string_to_depth(qPrintable(vString)), &displayed_dive);
|
2016-07-06 12:40:35 +00:00
|
|
|
|
}
|
|
|
|
|
pressure_t modpO2;
|
|
|
|
|
modpO2.mbar = prefs.decopo2;
|
2018-08-16 17:10:10 +00:00
|
|
|
|
cyl->depth = gas_mod(cyl->gasmix, modpO2, &displayed_dive, M_OR_FT(3, 10));
|
2016-07-06 12:40:32 +00:00
|
|
|
|
changed = true;
|
|
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
case MND:
|
|
|
|
|
if (CHANGED()) {
|
2018-02-25 12:51:41 +00:00
|
|
|
|
if (QString::compare(qPrintable(vString), "*") == 0) {
|
2016-07-06 12:40:35 +00:00
|
|
|
|
cyl->bestmix_he = true;
|
2017-03-06 12:27:39 +00:00
|
|
|
|
// Calculate fO2 for max. depth
|
2019-10-29 16:57:34 +00:00
|
|
|
|
cyl->gasmix.he = best_he(displayed_dive.maxdepth, &displayed_dive, prefs.o2narcotic, cyl->gasmix.o2);
|
2016-07-06 12:40:35 +00:00
|
|
|
|
} else {
|
|
|
|
|
cyl->bestmix_he = false;
|
|
|
|
|
// Calculate fHe for input depth
|
2019-10-29 16:57:34 +00:00
|
|
|
|
cyl->gasmix.he = best_he(string_to_depth(qPrintable(vString)), &displayed_dive, prefs.o2narcotic, cyl->gasmix.o2);
|
2016-07-06 12:40:35 +00:00
|
|
|
|
}
|
2016-07-06 12:40:32 +00:00
|
|
|
|
changed = true;
|
|
|
|
|
}
|
|
|
|
|
break;
|
2015-05-28 19:23:49 +00:00
|
|
|
|
case USE:
|
|
|
|
|
if (CHANGED()) {
|
2016-04-28 14:33:05 +00:00
|
|
|
|
int use = vString.toInt();
|
|
|
|
|
if (use > NUM_GAS_USE - 1 || use < 0)
|
|
|
|
|
use = 0;
|
|
|
|
|
cyl->cylinder_use = (enum cylinderuse)use;
|
2015-05-28 19:23:49 +00:00
|
|
|
|
changed = true;
|
|
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
dataChanged(index, index);
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
2018-05-21 15:53:42 +00:00
|
|
|
|
int CylindersModel::rowCount(const QModelIndex&) const
|
2015-05-28 19:23:49 +00:00
|
|
|
|
{
|
|
|
|
|
return rows;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void CylindersModel::add()
|
|
|
|
|
{
|
|
|
|
|
int row = rows;
|
2020-01-07 03:00:20 +00:00
|
|
|
|
cylinder_t cyl = empty_cylinder;
|
2019-08-04 16:44:57 +00:00
|
|
|
|
fill_default_cylinder(&displayed_dive, &cyl);
|
|
|
|
|
cyl.start = cyl.type.workingpressure;
|
|
|
|
|
cyl.manually_added = true;
|
|
|
|
|
cyl.cylinder_use = OC_GAS;
|
2015-05-28 19:23:49 +00:00
|
|
|
|
beginInsertRows(QModelIndex(), row, row);
|
2019-08-04 16:44:57 +00:00
|
|
|
|
add_to_cylinder_table(&displayed_dive.cylinders, row, cyl);
|
2015-05-28 19:23:49 +00:00
|
|
|
|
rows++;
|
|
|
|
|
changed = true;
|
|
|
|
|
endInsertRows();
|
2017-10-20 10:01:59 +00:00
|
|
|
|
emit dataChanged(createIndex(row, 0), createIndex(row, COLUMNS - 1));
|
2015-05-28 19:23:49 +00:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void CylindersModel::clear()
|
|
|
|
|
{
|
|
|
|
|
if (rows > 0) {
|
|
|
|
|
beginRemoveRows(QModelIndex(), 0, rows - 1);
|
|
|
|
|
endRemoveRows();
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
Tweak the "display_unused_tanks" preferences logic
This is really unrelated to my recent "multiple gas pressures" work, but
the test case from Gaetan Bisson showed that the logic for which
cylinders to show in the equipment tab was less than optimal.
We basically used to show only cylinders that were actively used, unless
you had the "display_unused_tanks" preference option set. That comes
from some dive computers reporting a *lot* of cylinders that the diver
really doesn't even have with him on the dive. And showing those extra
dummy cylinders gets pretty annoying after a time, which is why we
default to not showing unused tanks.
However, in Gaetan's case, he had a total of four cylinders on the dive:
the O2 and diluent bottle for the rebreather dive, and then bailout
bottles (both air and deco). And while the bailout bottles weren't
actually used, Gaetan had actually filled in all the pressure details
etc for them, and so you'd really expect them to show up. These were
*not* just some extraneous default cylinder filled in by an over-eager
dive computer.
But because the bailout wasn't used, the manual pressures at the end
were the same as at the beginning, and the "unused cylinder" logic
triggered anyway.
So tweak the logic a bit, and say that you show cylinder equipment not
only if it has been used on the dive, but also if it has any pressure
information for it.
So the o nly cylinders we don't show are the ones that really have no
interesting information at all, except for possibly the cylinder tank
type itself (which is exactly what the over-eager dive computer case
might fill in, usually in the form of a default cylinder type).
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-07-31 04:09:24 +00:00
|
|
|
|
static bool show_cylinder(struct dive *dive, int i)
|
|
|
|
|
{
|
2019-08-04 16:44:57 +00:00
|
|
|
|
if (i < 0 || i >= dive->cylinders.nr)
|
|
|
|
|
return false;
|
Tweak the "display_unused_tanks" preferences logic
This is really unrelated to my recent "multiple gas pressures" work, but
the test case from Gaetan Bisson showed that the logic for which
cylinders to show in the equipment tab was less than optimal.
We basically used to show only cylinders that were actively used, unless
you had the "display_unused_tanks" preference option set. That comes
from some dive computers reporting a *lot* of cylinders that the diver
really doesn't even have with him on the dive. And showing those extra
dummy cylinders gets pretty annoying after a time, which is why we
default to not showing unused tanks.
However, in Gaetan's case, he had a total of four cylinders on the dive:
the O2 and diluent bottle for the rebreather dive, and then bailout
bottles (both air and deco). And while the bailout bottles weren't
actually used, Gaetan had actually filled in all the pressure details
etc for them, and so you'd really expect them to show up. These were
*not* just some extraneous default cylinder filled in by an over-eager
dive computer.
But because the bailout wasn't used, the manual pressures at the end
were the same as at the beginning, and the "unused cylinder" logic
triggered anyway.
So tweak the logic a bit, and say that you show cylinder equipment not
only if it has been used on the dive, but also if it has any pressure
information for it.
So the o nly cylinders we don't show are the ones that really have no
interesting information at all, except for possibly the cylinder tank
type itself (which is exactly what the over-eager dive computer case
might fill in, usually in the form of a default cylinder type).
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-07-31 04:09:24 +00:00
|
|
|
|
if (is_cylinder_used(dive, i))
|
|
|
|
|
return true;
|
2019-08-04 16:44:57 +00:00
|
|
|
|
|
2019-08-04 20:13:49 +00:00
|
|
|
|
cylinder_t *cyl = get_cylinder(dive, i);
|
Tweak the "display_unused_tanks" preferences logic
This is really unrelated to my recent "multiple gas pressures" work, but
the test case from Gaetan Bisson showed that the logic for which
cylinders to show in the equipment tab was less than optimal.
We basically used to show only cylinders that were actively used, unless
you had the "display_unused_tanks" preference option set. That comes
from some dive computers reporting a *lot* of cylinders that the diver
really doesn't even have with him on the dive. And showing those extra
dummy cylinders gets pretty annoying after a time, which is why we
default to not showing unused tanks.
However, in Gaetan's case, he had a total of four cylinders on the dive:
the O2 and diluent bottle for the rebreather dive, and then bailout
bottles (both air and deco). And while the bailout bottles weren't
actually used, Gaetan had actually filled in all the pressure details
etc for them, and so you'd really expect them to show up. These were
*not* just some extraneous default cylinder filled in by an over-eager
dive computer.
But because the bailout wasn't used, the manual pressures at the end
were the same as at the beginning, and the "unused cylinder" logic
triggered anyway.
So tweak the logic a bit, and say that you show cylinder equipment not
only if it has been used on the dive, but also if it has any pressure
information for it.
So the o nly cylinders we don't show are the ones that really have no
interesting information at all, except for possibly the cylinder tank
type itself (which is exactly what the over-eager dive computer case
might fill in, usually in the form of a default cylinder type).
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-07-31 04:09:24 +00:00
|
|
|
|
if (cyl->start.mbar || cyl->sample_start.mbar ||
|
|
|
|
|
cyl->end.mbar || cyl->sample_end.mbar)
|
|
|
|
|
return true;
|
|
|
|
|
if (cyl->manually_added)
|
|
|
|
|
return true;
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* The cylinder has some data, but none of it is very interesting,
|
|
|
|
|
* it has no pressures and no gas switches. Do we want to show it?
|
|
|
|
|
*/
|
|
|
|
|
return prefs.display_unused_tanks;
|
|
|
|
|
}
|
|
|
|
|
|
2015-05-28 19:23:49 +00:00
|
|
|
|
void CylindersModel::updateDive()
|
|
|
|
|
{
|
2017-11-27 11:36:20 +00:00
|
|
|
|
#ifdef DEBUG_CYL
|
|
|
|
|
dump_cylinders(&displayed_dive, true);
|
|
|
|
|
#endif
|
2019-08-04 16:44:57 +00:00
|
|
|
|
beginResetModel();
|
|
|
|
|
// TODO: this is fundamentally broken - it assumes that unused cylinders are at
|
|
|
|
|
// the end. Fix by using a QSortFilterProxyModel.
|
2015-05-28 19:23:49 +00:00
|
|
|
|
rows = 0;
|
2019-08-04 16:44:57 +00:00
|
|
|
|
for (int i = 0; i < displayed_dive.cylinders.nr; ++i) {
|
|
|
|
|
if (show_cylinder(&displayed_dive, i))
|
|
|
|
|
++rows;
|
2015-05-28 19:23:49 +00:00
|
|
|
|
}
|
2019-08-04 16:44:57 +00:00
|
|
|
|
endResetModel();
|
2015-05-28 19:23:49 +00:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
Qt::ItemFlags CylindersModel::flags(const QModelIndex &index) const
|
|
|
|
|
{
|
2017-01-23 16:35:27 +00:00
|
|
|
|
if (index.column() == REMOVE || index.column() == USE)
|
2015-05-28 19:23:49 +00:00
|
|
|
|
return Qt::ItemIsEnabled;
|
|
|
|
|
return QAbstractItemModel::flags(index) | Qt::ItemIsEditable;
|
|
|
|
|
}
|
|
|
|
|
|
2019-11-26 22:41:56 +00:00
|
|
|
|
void CylindersModel::remove(QModelIndex index)
|
2015-05-28 19:23:49 +00:00
|
|
|
|
{
|
2017-01-23 16:35:27 +00:00
|
|
|
|
|
|
|
|
|
if (index.column() == USE) {
|
|
|
|
|
cylinder_t *cyl = cylinderAt(index);
|
|
|
|
|
if (cyl->cylinder_use == OC_GAS)
|
|
|
|
|
cyl->cylinder_use = NOT_USED;
|
|
|
|
|
else if (cyl->cylinder_use == NOT_USED)
|
|
|
|
|
cyl->cylinder_use = OC_GAS;
|
|
|
|
|
changed = true;
|
|
|
|
|
dataChanged(index, index);
|
|
|
|
|
return;
|
|
|
|
|
}
|
2019-08-04 16:44:57 +00:00
|
|
|
|
|
|
|
|
|
if (index.column() != REMOVE)
|
2015-05-28 19:23:49 +00:00
|
|
|
|
return;
|
2017-10-08 03:14:57 +00:00
|
|
|
|
|
2017-10-20 11:30:04 +00:00
|
|
|
|
if ((in_planner() && DivePlannerPointsModel::instance()->tankInUse(index.row())) ||
|
2017-11-29 09:16:00 +00:00
|
|
|
|
(!in_planner() && is_cylinder_prot(&displayed_dive, index.row())))
|
2017-10-20 11:30:04 +00:00
|
|
|
|
return;
|
2017-03-11 09:39:48 +00:00
|
|
|
|
|
2019-08-04 16:44:57 +00:00
|
|
|
|
beginRemoveRows(QModelIndex(), index.row(), index.row());
|
2015-05-28 19:23:49 +00:00
|
|
|
|
rows--;
|
2017-11-29 09:16:00 +00:00
|
|
|
|
remove_cylinder(&displayed_dive, index.row());
|
2019-08-04 16:44:57 +00:00
|
|
|
|
changed = true;
|
|
|
|
|
endRemoveRows();
|
|
|
|
|
|
|
|
|
|
// Create a mapping of cylinder indexes:
|
|
|
|
|
// 1) Fill mapping[0]..mapping[index-1] with 0..index
|
|
|
|
|
// 2) Set mapping[index] to -1
|
|
|
|
|
// 3) Fill mapping[index+1]..mapping[end] with index..
|
|
|
|
|
std::vector<int> mapping(displayed_dive.cylinders.nr + 1);
|
|
|
|
|
std::iota(mapping.begin(), mapping.begin() + index.row(), 0);
|
2017-11-29 09:16:00 +00:00
|
|
|
|
mapping[index.row()] = -1;
|
2019-08-04 16:44:57 +00:00
|
|
|
|
std::iota(mapping.begin() + index.row() + 1, mapping.end(), index.row());
|
2017-11-29 09:16:00 +00:00
|
|
|
|
|
2019-06-27 05:52:15 +00:00
|
|
|
|
cylinder_renumber(&displayed_dive, &mapping[0]);
|
2017-10-20 08:16:37 +00:00
|
|
|
|
if (in_planner())
|
2019-06-27 05:52:15 +00:00
|
|
|
|
DivePlannerPointsModel::instance()->cylinderRenumber(&mapping[0]);
|
2017-10-20 14:54:14 +00:00
|
|
|
|
changed = true;
|
2015-05-28 19:23:49 +00:00
|
|
|
|
}
|
2016-07-06 12:40:30 +00:00
|
|
|
|
|
2017-10-11 19:29:47 +00:00
|
|
|
|
void CylindersModel::moveAtFirst(int cylid)
|
|
|
|
|
{
|
|
|
|
|
cylinder_t temp_cyl;
|
|
|
|
|
|
|
|
|
|
beginMoveRows(QModelIndex(), cylid, cylid, QModelIndex(), 0);
|
2019-08-04 20:13:49 +00:00
|
|
|
|
memmove(&temp_cyl, get_cylinder(&displayed_dive, cylid), sizeof(temp_cyl));
|
2019-08-04 16:44:57 +00:00
|
|
|
|
for (int i = cylid - 1; i >= 0; i--)
|
2019-08-04 20:13:49 +00:00
|
|
|
|
memmove(get_cylinder(&displayed_dive, i + 1), get_cylinder(&displayed_dive, i), sizeof(temp_cyl));
|
|
|
|
|
memmove(get_cylinder(&displayed_dive, 0), &temp_cyl, sizeof(temp_cyl));
|
2019-08-04 16:44:57 +00:00
|
|
|
|
|
|
|
|
|
// Create a mapping of cylinder indexes:
|
|
|
|
|
// 1) Fill mapping[0]..mapping[cyl] with 0..index
|
|
|
|
|
// 2) Set mapping[cyl] to 0
|
|
|
|
|
// 3) Fill mapping[cyl+1]..mapping[end] with cyl..
|
|
|
|
|
std::vector<int> mapping(displayed_dive.cylinders.nr);
|
|
|
|
|
std::iota(mapping.begin(), mapping.begin() + cylid, 1);
|
2017-10-11 19:29:47 +00:00
|
|
|
|
mapping[cylid] = 0;
|
2019-08-04 16:44:57 +00:00
|
|
|
|
std::iota(mapping.begin() + (cylid + 1), mapping.end(), cylid);
|
2019-06-27 05:52:15 +00:00
|
|
|
|
cylinder_renumber(&displayed_dive, &mapping[0]);
|
2017-10-20 08:16:37 +00:00
|
|
|
|
if (in_planner())
|
2019-06-27 05:52:15 +00:00
|
|
|
|
DivePlannerPointsModel::instance()->cylinderRenumber(&mapping[0]);
|
2017-10-20 14:54:14 +00:00
|
|
|
|
changed = true;
|
|
|
|
|
endMoveRows();
|
2017-10-11 19:29:47 +00:00
|
|
|
|
}
|
|
|
|
|
|
2016-07-06 12:40:30 +00:00
|
|
|
|
void CylindersModel::updateDecoDepths(pressure_t olddecopo2)
|
|
|
|
|
{
|
|
|
|
|
pressure_t decopo2;
|
|
|
|
|
decopo2.mbar = prefs.decopo2;
|
2019-08-04 16:44:57 +00:00
|
|
|
|
for (int i = 0; i < displayed_dive.cylinders.nr; i++) {
|
2019-08-04 20:13:49 +00:00
|
|
|
|
cylinder_t *cyl = get_cylinder(&displayed_dive, i);
|
2016-07-06 12:40:30 +00:00
|
|
|
|
/* If the gas's deco MOD matches the old pO2, it will have been automatically calculated and should be updated.
|
|
|
|
|
* If they don't match, we should leave the user entered depth as it is */
|
2018-08-16 17:10:10 +00:00
|
|
|
|
if (cyl->depth.mm == gas_mod(cyl->gasmix, olddecopo2, &displayed_dive, M_OR_FT(3, 10)).mm) {
|
|
|
|
|
cyl->depth = gas_mod(cyl->gasmix, decopo2, &displayed_dive, M_OR_FT(3, 10));
|
2016-07-06 12:40:30 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
2019-08-04 16:44:57 +00:00
|
|
|
|
emit dataChanged(createIndex(0, 0), createIndex(displayed_dive.cylinders.nr - 1, COLUMNS - 1));
|
2016-07-06 12:40:30 +00:00
|
|
|
|
}
|
2016-07-06 12:40:35 +00:00
|
|
|
|
|
2017-03-13 07:25:32 +00:00
|
|
|
|
void CylindersModel::updateTrashIcon()
|
|
|
|
|
{
|
2019-08-04 16:44:57 +00:00
|
|
|
|
emit dataChanged(createIndex(0, 0), createIndex(displayed_dive.cylinders.nr - 1, 0));
|
2017-03-13 07:25:32 +00:00
|
|
|
|
}
|
|
|
|
|
|
2016-07-06 12:40:35 +00:00
|
|
|
|
bool CylindersModel::updateBestMixes()
|
|
|
|
|
{
|
|
|
|
|
// Check if any of the cylinders are best mixes, update if needed
|
|
|
|
|
bool gasUpdated = false;
|
2019-08-04 16:44:57 +00:00
|
|
|
|
for (int i = 0; i < displayed_dive.cylinders.nr; i++) {
|
2019-08-04 20:13:49 +00:00
|
|
|
|
cylinder_t *cyl = get_cylinder(&displayed_dive, i);
|
2016-07-06 12:40:35 +00:00
|
|
|
|
if (cyl->bestmix_o2) {
|
|
|
|
|
cyl->gasmix.o2 = best_o2(displayed_dive.maxdepth, &displayed_dive);
|
|
|
|
|
// fO2 + fHe must not be greater than 1
|
2018-08-16 17:10:10 +00:00
|
|
|
|
if (get_o2(cyl->gasmix) + get_he(cyl->gasmix) > 1000)
|
|
|
|
|
cyl->gasmix.he.permille = 1000 - get_o2(cyl->gasmix);
|
2016-07-06 12:40:35 +00:00
|
|
|
|
pressure_t modpO2;
|
|
|
|
|
modpO2.mbar = prefs.decopo2;
|
2018-08-16 17:10:10 +00:00
|
|
|
|
cyl->depth = gas_mod(cyl->gasmix, modpO2, &displayed_dive, M_OR_FT(3, 10));
|
2016-07-06 12:40:35 +00:00
|
|
|
|
gasUpdated = true;
|
|
|
|
|
}
|
|
|
|
|
if (cyl->bestmix_he) {
|
2019-10-29 16:57:34 +00:00
|
|
|
|
cyl->gasmix.he = best_he(displayed_dive.maxdepth, &displayed_dive, prefs.o2narcotic, cyl->gasmix.o2);
|
2016-07-06 12:40:35 +00:00
|
|
|
|
// fO2 + fHe must not be greater than 1
|
2018-08-16 17:10:10 +00:00
|
|
|
|
if (get_o2(cyl->gasmix) + get_he(cyl->gasmix) > 1000)
|
|
|
|
|
cyl->gasmix.o2.permille = 1000 - get_he(cyl->gasmix);
|
2016-07-06 12:40:35 +00:00
|
|
|
|
gasUpdated = true;
|
|
|
|
|
}
|
|
|
|
|
}
|
2016-07-06 12:40:37 +00:00
|
|
|
|
/* This slot is called when the bottom pO2 and END preferences are updated, we want to
|
|
|
|
|
* emit dataChanged so MOD and MND are refreshed, even if the gas mix hasn't been changed */
|
2017-12-01 11:49:38 +00:00
|
|
|
|
if (gasUpdated)
|
2019-08-04 16:44:57 +00:00
|
|
|
|
emit dataChanged(createIndex(0, 0), createIndex(displayed_dive.cylinders.nr - 1, COLUMNS - 1));
|
2016-07-06 12:40:35 +00:00
|
|
|
|
return gasUpdated;
|
|
|
|
|
}
|
2019-02-23 21:09:34 +00:00
|
|
|
|
|
2019-06-23 07:22:26 +00:00
|
|
|
|
void CylindersModel::cylindersReset(const QVector<dive *> &dives)
|
2019-02-23 21:09:34 +00:00
|
|
|
|
{
|
|
|
|
|
// This model only concerns the currently displayed dive. If this is not among the
|
|
|
|
|
// dives that had their cylinders reset, exit.
|
|
|
|
|
if (!current_dive || std::find(dives.begin(), dives.end(), current_dive) == dives.end())
|
|
|
|
|
return;
|
|
|
|
|
|
|
|
|
|
// Copy the cylinders from the current dive to the displayed dive.
|
2019-08-04 16:44:57 +00:00
|
|
|
|
copy_cylinders(¤t_dive->cylinders, &displayed_dive.cylinders);
|
2019-02-23 21:09:34 +00:00
|
|
|
|
|
|
|
|
|
// And update the model..
|
|
|
|
|
updateDive();
|
|
|
|
|
}
|