subsurface/core/windowtitleupdate.cpp

// SPDX-License-Identifier: GPL-2.0
#include "windowtitleupdate.h"

WindowTitleUpdate windowTitleUpdate;

extern "C" void updateWindowTitle()
{
	emit windowTitleUpdate.updateTitle();
}
Add SPDX header to remaining core files Signed-off-by: Dirk Hohndel <dirk@hohndel.org> 2017-04-27 20:24:53 +02:00			`// SPDX-License-Identifier: GPL-2.0`
Code cleanup: implement window title update via signal This seems quite convoluted to me but I can't seem to make a more straight forward implementation work. The idea is that core code should never directly call into the UI. So instead the core code (this is C code) calls a helper function. That helper function calls a member function of a class which in return emits a signal. The UI code connects to that signal and acts accordingly when it is received. Signed-off-by: Dirk Hohndel <dirk@hohndel.org> 2015-06-16 06:04:34 -07:00			`#include "windowtitleupdate.h"`

Cleanup: Make WindowsTitleUpdate a global object WindowsTitleUpdate is such a trivial object (a QObject with a single signal and no own state), that it's not really understandable why it would need all that "singleton" boiler-plate. Just make it a default constructed/destructed global object. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at> 2018-07-30 20:59:07 +02:00			`WindowTitleUpdate windowTitleUpdate;`
Code cleanup: implement window title update via signal This seems quite convoluted to me but I can't seem to make a more straight forward implementation work. The idea is that core code should never directly call into the UI. So instead the core code (this is C code) calls a helper function. That helper function calls a member function of a class which in return emits a signal. The UI code connects to that signal and acts accordingly when it is received. Signed-off-by: Dirk Hohndel <dirk@hohndel.org> 2015-06-16 06:04:34 -07:00
			`extern "C" void updateWindowTitle()`
			`{`
Cleanup: Make WindowsTitleUpdate a global object WindowsTitleUpdate is such a trivial object (a QObject with a single signal and no own state), that it's not really understandable why it would need all that "singleton" boiler-plate. Just make it a default constructed/destructed global object. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at> 2018-07-30 20:59:07 +02:00			`emit windowTitleUpdate.updateTitle();`
Code cleanup: implement window title update via signal This seems quite convoluted to me but I can't seem to make a more straight forward implementation work. The idea is that core code should never directly call into the UI. So instead the core code (this is C code) calls a helper function. That helper function calls a member function of a class which in return emits a signal. The UI code connects to that signal and acts accordingly when it is received. Signed-off-by: Dirk Hohndel <dirk@hohndel.org> 2015-06-16 06:04:34 -07:00			`}`