mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2024-12-01 06:30:26 +00:00
Code Issues Projects Releases Packages Wiki Activity
subsurface/tests/testqPrefCloudStorage.cpp

251 lines
10 KiB
C++
Raw Normal View History

tests: add qPrefCloudStorage testcases add test cases to secure struct preferences and qPrefCloudStorage work together Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-14 15:31:51 +00:00
// SPDX-License-Identifier: GPL-2.0
#include "testqPrefCloudStorage.h"
#include "core/pref.h"
#include "core/qthelper.h"
core/settings ... : remove qPref* includes in qPref.h reduce number of includes by removing qPref* includes in qPref.h Signed-off-by: Jan Iversen <jani@apache.org>
2018-09-08 17:46:11 +00:00
#include "core/settings/qPrefCloudStorage.h"
tests: add qPrefCloudStorage testcases add test cases to secure struct preferences and qPrefCloudStorage work together Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-14 15:31:51 +00:00
#include <QTest>
tests: add signal test to call testqPref*cpp Add signal testing of all variables this commit contains all qPref* that work directly followup commit will do changes to qPref* to make signals work Signed-off-by: Jan Iversen <jani@apache.org>
2018-08-28 10:33:47 +00:00
#include <QSignalSpy>
tests: add qPrefCloudStorage testcases add test cases to secure struct preferences and qPrefCloudStorage work together Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-14 15:31:51 +00:00
void TestQPrefCloudStorage::initTestCase()
{
QCoreApplication::setOrganizationName("Subsurface");
QCoreApplication::setOrganizationDomain("subsurface.hohndel.org");
QCoreApplication::setApplicationName("SubsurfaceTestQPrefCloudStorage");
}
void TestQPrefCloudStorage::test_struct_get()
{
// Test struct pref -> get func.
auto tst = qPrefCloudStorage::instance();
Prefs: add bool preference cloud_auto_sync [1/3] With removal of the git_local_only from the preferences (see ae653703a5d3f), the users choice, in the mobile app, was not stored any more in between sessions. This resulted in issue 1725. So, in order to store that user preference, we need a new preference. This is added here, but its not yet hooked up in the app yet. This deals only with the preference handling. And adapted tests are included. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-10-08 14:15:53 +00:00
prefs.cloud_auto_sync = true;
preferences: use std::string in struct preferences This is a messy commit, because the "qPref" system relies heavily on QString, which means lots of conversions between the two worlds. Ultimately, I plan to base the preferences system on std::string and only convert to QString when pushing through Qt's property system or when writing into Qt's settings. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2024-06-13 20:59:32 +00:00
prefs.cloud_base_url = "new url";
prefs.cloud_storage_email = "myEmail";
prefs.cloud_storage_email_encoded = "encodedMyEMail";
prefs.cloud_storage_password = "more secret";
prefs.cloud_storage_pin = "a pin";
tests: add qPrefCloudStorage testcases add test cases to secure struct preferences and qPrefCloudStorage work together Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-14 15:31:51 +00:00
prefs.cloud_timeout = 117;
core: declare cloud_status in qPrefCloudStorage qml declaration of cloud_status (defined in pref.h) does not belong in qPref.h but in qPrefCloudStorage Signed-off-by: Jan Iversen <jani@apache.org>
2018-09-02 14:22:16 +00:00
prefs.cloud_verification_status = qPrefCloudStorage::CS_NOCLOUD;
tests: add qPrefCloudStorage testcases add test cases to secure struct preferences and qPrefCloudStorage work together Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-14 15:31:51 +00:00
prefs.save_password_local = true;
Prefs: add bool preference cloud_auto_sync [1/3] With removal of the git_local_only from the preferences (see ae653703a5d3f), the users choice, in the mobile app, was not stored any more in between sessions. This resulted in issue 1725. So, in order to store that user preference, we need a new preference. This is added here, but its not yet hooked up in the app yet. This deals only with the preference handling. And adapted tests are included. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-10-08 14:15:53 +00:00
QCOMPARE(tst->cloud_auto_sync(), prefs.cloud_auto_sync);
preferences: use std::string in struct preferences This is a messy commit, because the "qPref" system relies heavily on QString, which means lots of conversions between the two worlds. Ultimately, I plan to base the preferences system on std::string and only convert to QString when pushing through Qt's property system or when writing into Qt's settings. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2024-06-13 20:59:32 +00:00
QCOMPARE(tst->cloud_base_url(), QString::fromStdString(prefs.cloud_base_url));
QCOMPARE(tst->cloud_storage_email(), QString::fromStdString(prefs.cloud_storage_email));
QCOMPARE(tst->cloud_storage_email_encoded(), QString::fromStdString(prefs.cloud_storage_email_encoded));
QCOMPARE(tst->cloud_storage_password(), QString::fromStdString(prefs.cloud_storage_password));
QCOMPARE(tst->cloud_storage_pin(), QString::fromStdString(prefs.cloud_storage_pin));
tests: add qPrefCloudStorage testcases add test cases to secure struct preferences and qPrefCloudStorage work together Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-14 15:31:51 +00:00
QCOMPARE(tst->cloud_timeout(), (int)prefs.cloud_timeout);
QCOMPARE(tst->cloud_verification_status(), (int)prefs.cloud_verification_status);
QCOMPARE(tst->save_password_local(), prefs.save_password_local);
}
void TestQPrefCloudStorage::test_set_struct()
{
// Test set func -> struct pref
auto tst = qPrefCloudStorage::instance();
Prefs: add bool preference cloud_auto_sync [1/3] With removal of the git_local_only from the preferences (see ae653703a5d3f), the users choice, in the mobile app, was not stored any more in between sessions. This resulted in issue 1725. So, in order to store that user preference, we need a new preference. This is added here, but its not yet hooked up in the app yet. This deals only with the preference handling. And adapted tests are included. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-10-08 14:15:53 +00:00
tst->set_cloud_auto_sync(false);
tests: add qPrefCloudStorage testcases add test cases to secure struct preferences and qPrefCloudStorage work together Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-14 15:31:51 +00:00
tst->set_cloud_base_url("t2 base");
tst->set_cloud_storage_email("t2 email");
tst->set_cloud_storage_email_encoded("t2 email2");
tst->set_cloud_storage_password("t2 pass2");
tst->set_cloud_storage_pin("t2 pin");
tst->set_cloud_timeout(123);
core: declare cloud_status in qPrefCloudStorage qml declaration of cloud_status (defined in pref.h) does not belong in qPref.h but in qPrefCloudStorage Signed-off-by: Jan Iversen <jani@apache.org>
2018-09-02 14:22:16 +00:00
tst->set_cloud_verification_status(qPrefCloudStorage::CS_VERIFIED);
tests: add qPrefCloudStorage testcases add test cases to secure struct preferences and qPrefCloudStorage work together Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-14 15:31:51 +00:00
tst->set_save_password_local(false);
Prefs: add bool preference cloud_auto_sync [1/3] With removal of the git_local_only from the preferences (see ae653703a5d3f), the users choice, in the mobile app, was not stored any more in between sessions. This resulted in issue 1725. So, in order to store that user preference, we need a new preference. This is added here, but its not yet hooked up in the app yet. This deals only with the preference handling. And adapted tests are included. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-10-08 14:15:53 +00:00
QCOMPARE(prefs.cloud_auto_sync, false);
preferences: use std::string in struct preferences This is a messy commit, because the "qPref" system relies heavily on QString, which means lots of conversions between the two worlds. Ultimately, I plan to base the preferences system on std::string and only convert to QString when pushing through Qt's property system or when writing into Qt's settings. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2024-06-13 20:59:32 +00:00
QCOMPARE(QString::fromStdString(prefs.cloud_base_url), QString("t2 base"));
QCOMPARE(QString::fromStdString(prefs.cloud_storage_email), QString("t2 email"));
QCOMPARE(QString::fromStdString(prefs.cloud_storage_email_encoded), QString("t2 email2"));
QCOMPARE(QString::fromStdString(prefs.cloud_storage_password), QString("t2 pass2"));
QCOMPARE(QString::fromStdString(prefs.cloud_storage_pin), QString("t2 pin"));
tests: add qPrefCloudStorage testcases add test cases to secure struct preferences and qPrefCloudStorage work together Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-14 15:31:51 +00:00
QCOMPARE((int)prefs.cloud_timeout, 123);
core: declare cloud_status in qPrefCloudStorage qml declaration of cloud_status (defined in pref.h) does not belong in qPref.h but in qPrefCloudStorage Signed-off-by: Jan Iversen <jani@apache.org>
2018-09-02 14:22:16 +00:00
QCOMPARE((int)prefs.cloud_verification_status, (int)qPrefCloudStorage::CS_VERIFIED);
tests: add qPrefCloudStorage testcases add test cases to secure struct preferences and qPrefCloudStorage work together Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-14 15:31:51 +00:00
QCOMPARE(prefs.save_password_local, false);
}
void TestQPrefCloudStorage::test_set_load_struct()
{
Whitespace cleanup tests Again, entirely script based. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2018-07-25 19:39:04 +00:00
// test set func -> load -> struct pref
tests: add qPrefCloudStorage testcases add test cases to secure struct preferences and qPrefCloudStorage work together Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-14 15:31:51 +00:00
auto tst = qPrefCloudStorage::instance();
tst->set_cloud_base_url("t3 base");
cloudstorage: adapt tests The code assumes that prefs.cloud_base_url is non NULL. Allowing that to be NULL makes no sense during normal operation of the app. Yet, most of the tests don't initialize the prefs at all. Making things worse, if we do correctly initialize the prefs (so as to reasonably approximate the behavior when running the app), things break because some of the reference outputs assume that the prefs are unset. This deserves fixing. For now, simply make sure that cloud_base_url is set for all the tests that try to parse files. Additionally, the semantics how cloud_base_url is saved to disk have changed, so adjust the test for those prefs accordingly. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2021-04-16 13:47:51 +00:00
tst->store_cloud_base_url("t3 base"); // the base URL is no longer automatically saved to disk
tests: add qPrefCloudStorage testcases add test cases to secure struct preferences and qPrefCloudStorage work together Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-14 15:31:51 +00:00
tst->set_cloud_storage_email("t3 email");
tst->set_cloud_storage_email_encoded("t3 email2");
tst->set_save_password_local(true);
Prefs: add bool preference cloud_auto_sync [1/3] With removal of the git_local_only from the preferences (see ae653703a5d3f), the users choice, in the mobile app, was not stored any more in between sessions. This resulted in issue 1725. So, in order to store that user preference, we need a new preference. This is added here, but its not yet hooked up in the app yet. This deals only with the preference handling. And adapted tests are included. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-10-08 14:15:53 +00:00
tst->set_cloud_auto_sync(true);
tests: add qPrefCloudStorage testcases add test cases to secure struct preferences and qPrefCloudStorage work together Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-14 15:31:51 +00:00
tst->set_cloud_storage_password("t3 pass2");
tst->set_cloud_storage_pin("t3 pin");
tst->set_cloud_timeout(321);
core: declare cloud_status in qPrefCloudStorage qml declaration of cloud_status (defined in pref.h) does not belong in qPref.h but in qPrefCloudStorage Signed-off-by: Jan Iversen <jani@apache.org>
2018-09-02 14:22:16 +00:00
tst->set_cloud_verification_status(qPrefCloudStorage::CS_NOCLOUD);
tests: add qPrefCloudStorage testcases add test cases to secure struct preferences and qPrefCloudStorage work together Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-14 15:31:51 +00:00
Prefs: add bool preference cloud_auto_sync [1/3] With removal of the git_local_only from the preferences (see ae653703a5d3f), the users choice, in the mobile app, was not stored any more in between sessions. This resulted in issue 1725. So, in order to store that user preference, we need a new preference. This is added here, but its not yet hooked up in the app yet. This deals only with the preference handling. And adapted tests are included. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-10-08 14:15:53 +00:00
prefs.cloud_auto_sync = false;
preferences: use std::string in struct preferences This is a messy commit, because the "qPref" system relies heavily on QString, which means lots of conversions between the two worlds. Ultimately, I plan to base the preferences system on std::string and only convert to QString when pushing through Qt's property system or when writing into Qt's settings. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2024-06-13 20:59:32 +00:00
prefs.cloud_base_url = "error1";
prefs.cloud_storage_email = "error1";
prefs.cloud_storage_email_encoded = "error1";
prefs.cloud_storage_password = "error1";
prefs.cloud_storage_pin = "error1";
tests: add qPrefCloudStorage testcases add test cases to secure struct preferences and qPrefCloudStorage work together Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-14 15:31:51 +00:00
prefs.cloud_timeout = 324;
core: declare cloud_status in qPrefCloudStorage qml declaration of cloud_status (defined in pref.h) does not belong in qPref.h but in qPrefCloudStorage Signed-off-by: Jan Iversen <jani@apache.org>
2018-09-02 14:22:16 +00:00
prefs.cloud_verification_status = qPrefCloudStorage::CS_VERIFIED;
tests: add qPrefCloudStorage testcases add test cases to secure struct preferences and qPrefCloudStorage work together Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-14 15:31:51 +00:00
prefs.save_password_local = false;
tst->load();
Prefs: add bool preference cloud_auto_sync [1/3] With removal of the git_local_only from the preferences (see ae653703a5d3f), the users choice, in the mobile app, was not stored any more in between sessions. This resulted in issue 1725. So, in order to store that user preference, we need a new preference. This is added here, but its not yet hooked up in the app yet. This deals only with the preference handling. And adapted tests are included. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-10-08 14:15:53 +00:00
QCOMPARE(prefs.cloud_auto_sync, true);
preferences: use std::string in struct preferences This is a messy commit, because the "qPref" system relies heavily on QString, which means lots of conversions between the two worlds. Ultimately, I plan to base the preferences system on std::string and only convert to QString when pushing through Qt's property system or when writing into Qt's settings. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2024-06-13 20:59:32 +00:00
QCOMPARE(QString::fromStdString(prefs.cloud_base_url), QString("t3 base"));
QCOMPARE(QString::fromStdString(prefs.cloud_storage_email), QString("t3 email"));
QCOMPARE(QString::fromStdString(prefs.cloud_storage_email_encoded), QString("t3 email2"));
QCOMPARE(QString::fromStdString(prefs.cloud_storage_password), QString("t3 pass2"));
QCOMPARE(QString::fromStdString(prefs.cloud_storage_pin), QString("t3 pin"));
tests: add qPrefCloudStorage testcases add test cases to secure struct preferences and qPrefCloudStorage work together Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-14 15:31:51 +00:00
QCOMPARE((int)prefs.cloud_timeout, 321);
core: declare cloud_status in qPrefCloudStorage qml declaration of cloud_status (defined in pref.h) does not belong in qPref.h but in qPrefCloudStorage Signed-off-by: Jan Iversen <jani@apache.org>
2018-09-02 14:22:16 +00:00
QCOMPARE((int)prefs.cloud_verification_status, (int)qPrefCloudStorage::CS_NOCLOUD);
tests: add qPrefCloudStorage testcases add test cases to secure struct preferences and qPrefCloudStorage work together Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-14 15:31:51 +00:00
QCOMPARE(prefs.save_password_local, true);
}
void TestQPrefCloudStorage::test_struct_disk()
{
// test struct prefs -> disk
auto tst = qPrefCloudStorage::instance();
preferences: use std::string in struct preferences This is a messy commit, because the "qPref" system relies heavily on QString, which means lots of conversions between the two worlds. Ultimately, I plan to base the preferences system on std::string and only convert to QString when pushing through Qt's property system or when writing into Qt's settings. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2024-06-13 20:59:32 +00:00
prefs.cloud_base_url = "t4 base";
cloudstorage: adapt tests The code assumes that prefs.cloud_base_url is non NULL. Allowing that to be NULL makes no sense during normal operation of the app. Yet, most of the tests don't initialize the prefs at all. Making things worse, if we do correctly initialize the prefs (so as to reasonably approximate the behavior when running the app), things break because some of the reference outputs assume that the prefs are unset. This deserves fixing. For now, simply make sure that cloud_base_url is set for all the tests that try to parse files. Additionally, the semantics how cloud_base_url is saved to disk have changed, so adjust the test for those prefs accordingly. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2021-04-16 13:47:51 +00:00
tst->store_cloud_base_url("t4 base"); // the base URL is no longer automatically saved to disk
preferences: use std::string in struct preferences This is a messy commit, because the "qPref" system relies heavily on QString, which means lots of conversions between the two worlds. Ultimately, I plan to base the preferences system on std::string and only convert to QString when pushing through Qt's property system or when writing into Qt's settings. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2024-06-13 20:59:32 +00:00
prefs.cloud_storage_email =("t4 email");
prefs.cloud_storage_email_encoded = "t4 email2";
tests: add qPrefCloudStorage testcases add test cases to secure struct preferences and qPrefCloudStorage work together Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-14 15:31:51 +00:00
prefs.save_password_local = true;
Prefs: add bool preference cloud_auto_sync [1/3] With removal of the git_local_only from the preferences (see ae653703a5d3f), the users choice, in the mobile app, was not stored any more in between sessions. This resulted in issue 1725. So, in order to store that user preference, we need a new preference. This is added here, but its not yet hooked up in the app yet. This deals only with the preference handling. And adapted tests are included. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-10-08 14:15:53 +00:00
prefs.cloud_auto_sync = true;
preferences: use std::string in struct preferences This is a messy commit, because the "qPref" system relies heavily on QString, which means lots of conversions between the two worlds. Ultimately, I plan to base the preferences system on std::string and only convert to QString when pushing through Qt's property system or when writing into Qt's settings. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2024-06-13 20:59:32 +00:00
prefs.cloud_storage_password = "t4 pass2";
prefs.cloud_storage_pin = "t4 pin";
tests: add qPrefCloudStorage testcases add test cases to secure struct preferences and qPrefCloudStorage work together Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-14 15:31:51 +00:00
prefs.cloud_timeout = 123;
core: declare cloud_status in qPrefCloudStorage qml declaration of cloud_status (defined in pref.h) does not belong in qPref.h but in qPrefCloudStorage Signed-off-by: Jan Iversen <jani@apache.org>
2018-09-02 14:22:16 +00:00
prefs.cloud_verification_status = qPrefCloudStorage::CS_VERIFIED;
tests: add qPrefCloudStorage testcases add test cases to secure struct preferences and qPrefCloudStorage work together Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-14 15:31:51 +00:00
tst->sync();
Prefs: add bool preference cloud_auto_sync [1/3] With removal of the git_local_only from the preferences (see ae653703a5d3f), the users choice, in the mobile app, was not stored any more in between sessions. This resulted in issue 1725. So, in order to store that user preference, we need a new preference. This is added here, but its not yet hooked up in the app yet. This deals only with the preference handling. And adapted tests are included. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-10-08 14:15:53 +00:00
prefs.cloud_auto_sync = false;
preferences: use std::string in struct preferences This is a messy commit, because the "qPref" system relies heavily on QString, which means lots of conversions between the two worlds. Ultimately, I plan to base the preferences system on std::string and only convert to QString when pushing through Qt's property system or when writing into Qt's settings. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2024-06-13 20:59:32 +00:00
prefs.cloud_base_url = "error1";
prefs.cloud_storage_email = "error1";
prefs.cloud_storage_email_encoded = "error1";
prefs.cloud_storage_password = "error1";
prefs.cloud_storage_pin = "error1";
tests: add qPrefCloudStorage testcases add test cases to secure struct preferences and qPrefCloudStorage work together Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-14 15:31:51 +00:00
prefs.cloud_timeout = 324;
core: declare cloud_status in qPrefCloudStorage qml declaration of cloud_status (defined in pref.h) does not belong in qPref.h but in qPrefCloudStorage Signed-off-by: Jan Iversen <jani@apache.org>
2018-09-02 14:22:16 +00:00
prefs.cloud_verification_status = qPrefCloudStorage::CS_VERIFIED;
tests: add qPrefCloudStorage testcases add test cases to secure struct preferences and qPrefCloudStorage work together Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-14 15:31:51 +00:00
prefs.save_password_local = false;
tst->load();
Prefs: add bool preference cloud_auto_sync [1/3] With removal of the git_local_only from the preferences (see ae653703a5d3f), the users choice, in the mobile app, was not stored any more in between sessions. This resulted in issue 1725. So, in order to store that user preference, we need a new preference. This is added here, but its not yet hooked up in the app yet. This deals only with the preference handling. And adapted tests are included. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-10-08 14:15:53 +00:00
QCOMPARE(prefs.cloud_auto_sync, true);
preferences: use std::string in struct preferences This is a messy commit, because the "qPref" system relies heavily on QString, which means lots of conversions between the two worlds. Ultimately, I plan to base the preferences system on std::string and only convert to QString when pushing through Qt's property system or when writing into Qt's settings. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2024-06-13 20:59:32 +00:00
QCOMPARE(QString::fromStdString(prefs.cloud_base_url), QString("t4 base"));
QCOMPARE(QString::fromStdString(prefs.cloud_storage_email), QString("t4 email"));
QCOMPARE(QString::fromStdString(prefs.cloud_storage_email_encoded), QString("t4 email2"));
QCOMPARE(QString::fromStdString(prefs.cloud_storage_password), QString("t4 pass2"));
QCOMPARE(QString::fromStdString(prefs.cloud_storage_pin), QString("t4 pin"));
tests: add qPrefCloudStorage testcases add test cases to secure struct preferences and qPrefCloudStorage work together Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-14 15:31:51 +00:00
QCOMPARE((int)prefs.cloud_timeout, 123);
core: declare cloud_status in qPrefCloudStorage qml declaration of cloud_status (defined in pref.h) does not belong in qPref.h but in qPrefCloudStorage Signed-off-by: Jan Iversen <jani@apache.org>
2018-09-02 14:22:16 +00:00
QCOMPARE((int)prefs.cloud_verification_status, (int)qPrefCloudStorage::CS_VERIFIED);
tests: add qPrefCloudStorage testcases add test cases to secure struct preferences and qPrefCloudStorage work together Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-14 15:31:51 +00:00
QCOMPARE(prefs.save_password_local, true);
}
void TestQPrefCloudStorage::test_multiple()
{
// test multiple instances have the same information
prefs.cloud_timeout = 25;
auto tst = qPrefCloudStorage::instance();
tests: correct testqPref*.cpp to use static qPref* functions. qPref* set/get functions are static. remove creation of qPref* instances, reference static functions. Signed-off-by: Jan Iversen <jan@casacondor.com>
2019-11-23 16:40:56 +00:00
QCOMPARE(tst->cloud_timeout(), qPrefCloudStorage::cloud_timeout());
QCOMPARE(qPrefCloudStorage::cloud_timeout(), 25);
tests: add qPrefCloudStorage testcases add test cases to secure struct preferences and qPrefCloudStorage work together Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-14 15:31:51 +00:00
}
Whitespace cleanup tests Again, entirely script based. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2018-07-25 19:39:04 +00:00
#define TEST(METHOD, VALUE) \
QCOMPARE(METHOD, VALUE); \
cloud->sync(); \
cloud->load(); \
QCOMPARE(METHOD, VALUE);
tests: move CloudStorage test from testpreferences Remove CloudStorage test in testpreferences add the same CloudStorage tests to testqPrefCloudStorage Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-15 11:53:03 +00:00
void TestQPrefCloudStorage::test_oldPreferences()
{
auto cloud = qPrefCloudStorage::instance();
cloud->set_cloud_base_url("test_one");
cloudstorage: adapt tests The code assumes that prefs.cloud_base_url is non NULL. Allowing that to be NULL makes no sense during normal operation of the app. Yet, most of the tests don't initialize the prefs at all. Making things worse, if we do correctly initialize the prefs (so as to reasonably approximate the behavior when running the app), things break because some of the reference outputs assume that the prefs are unset. This deserves fixing. For now, simply make sure that cloud_base_url is set for all the tests that try to parse files. Additionally, the semantics how cloud_base_url is saved to disk have changed, so adjust the test for those prefs accordingly. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2021-04-16 13:47:51 +00:00
cloud->store_cloud_base_url("test_one");
tests: move CloudStorage test from testpreferences Remove CloudStorage test in testpreferences add the same CloudStorage tests to testqPrefCloudStorage Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-15 11:53:03 +00:00
TEST(cloud->cloud_base_url(), QStringLiteral("test_one"));
cloud->set_cloud_base_url("test_two");
cloudstorage: adapt tests The code assumes that prefs.cloud_base_url is non NULL. Allowing that to be NULL makes no sense during normal operation of the app. Yet, most of the tests don't initialize the prefs at all. Making things worse, if we do correctly initialize the prefs (so as to reasonably approximate the behavior when running the app), things break because some of the reference outputs assume that the prefs are unset. This deserves fixing. For now, simply make sure that cloud_base_url is set for all the tests that try to parse files. Additionally, the semantics how cloud_base_url is saved to disk have changed, so adjust the test for those prefs accordingly. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2021-04-16 13:47:51 +00:00
cloud->store_cloud_base_url("test_two");
tests: move CloudStorage test from testpreferences Remove CloudStorage test in testpreferences add the same CloudStorage tests to testqPrefCloudStorage Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-15 11:53:03 +00:00
TEST(cloud->cloud_base_url(), QStringLiteral("test_two"));
cloud->set_cloud_storage_email("tomaz@subsurface.com");
TEST(cloud->cloud_storage_email(), QStringLiteral("tomaz@subsurface.com"));
cloud->set_cloud_storage_email("tomaz@gmail.com");
TEST(cloud->cloud_storage_email(), QStringLiteral("tomaz@gmail.com"));
cloud->set_cloud_storage_password("ABCDE");
TEST(cloud->cloud_storage_password(), QStringLiteral("ABCDE"));
cloud->set_cloud_storage_password("ABCABC");
TEST(cloud->cloud_storage_password(), QStringLiteral("ABCABC"));
Prefs: add bool preference cloud_auto_sync [1/3] With removal of the git_local_only from the preferences (see ae653703a5d3f), the users choice, in the mobile app, was not stored any more in between sessions. This resulted in issue 1725. So, in order to store that user preference, we need a new preference. This is added here, but its not yet hooked up in the app yet. This deals only with the preference handling. And adapted tests are included. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-10-08 14:15:53 +00:00
cloud->set_cloud_auto_sync(true);
TEST(cloud->cloud_auto_sync(), true);
cloud->set_cloud_auto_sync(false);
TEST(cloud->cloud_auto_sync(), false);
tests: move CloudStorage test from testpreferences Remove CloudStorage test in testpreferences add the same CloudStorage tests to testqPrefCloudStorage Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-15 11:53:03 +00:00
cloud->set_save_password_local(true);
TEST(cloud->save_password_local(), true);
cloud->set_save_password_local(false);
TEST(cloud->save_password_local(), false);
cloud->set_cloud_verification_status(0);
TEST(cloud->cloud_verification_status(), 0);
cloud->set_cloud_verification_status(1);
TEST(cloud->cloud_verification_status(), 1);
}
tests: add signal test to call testqPref*cpp Add signal testing of all variables this commit contains all qPref* that work directly followup commit will do changes to qPref* to make signals work Signed-off-by: Jan Iversen <jani@apache.org>
2018-08-28 10:33:47 +00:00
void TestQPrefCloudStorage::test_signals()
{
tests: use new style syntax to connect QSignalSpy Signed-off-by: Rolf Eike Beer <eike@sf-mail.de>
2019-03-31 13:02:03 +00:00
QSignalSpy spy1(qPrefCloudStorage::instance(), &qPrefCloudStorage::cloud_base_urlChanged);
QSignalSpy spy2(qPrefCloudStorage::instance(), &qPrefCloudStorage::cloud_storage_emailChanged);
QSignalSpy spy3(qPrefCloudStorage::instance(), &qPrefCloudStorage::cloud_storage_email_encodedChanged);
QSignalSpy spy4(qPrefCloudStorage::instance(), &qPrefCloudStorage::cloud_storage_passwordChanged);
QSignalSpy spy5(qPrefCloudStorage::instance(), &qPrefCloudStorage::cloud_storage_pinChanged);
QSignalSpy spy6(qPrefCloudStorage::instance(), &qPrefCloudStorage::cloud_timeoutChanged);
QSignalSpy spy7(qPrefCloudStorage::instance(), &qPrefCloudStorage::cloud_verification_statusChanged);
QSignalSpy spy9(qPrefCloudStorage::instance(), &qPrefCloudStorage::save_password_localChanged);
QSignalSpy spy10(qPrefCloudStorage::instance(), &qPrefCloudStorage::cloud_auto_syncChanged);
tests: add signal test to call testqPref*cpp Add signal testing of all variables this commit contains all qPref* that work directly followup commit will do changes to qPref* to make signals work Signed-off-by: Jan Iversen <jani@apache.org>
2018-08-28 10:33:47 +00:00
qPrefCloudStorage::set_cloud_base_url("signal url");
qPrefCloudStorage::set_cloud_storage_email("signal myEmail");
qPrefCloudStorage::set_cloud_storage_email_encoded("signal encodedMyEMail");
qPrefCloudStorage::set_cloud_storage_password("signal more secret");
qPrefCloudStorage::set_cloud_storage_pin("signal a pin");
qPrefCloudStorage::set_cloud_timeout(11);
qPrefCloudStorage::set_cloud_verification_status(qPrefCloudStorage::CS_VERIFIED);
qPrefCloudStorage::set_save_password_local(true);
Prefs: add bool preference cloud_auto_sync [1/3] With removal of the git_local_only from the preferences (see ae653703a5d3f), the users choice, in the mobile app, was not stored any more in between sessions. This resulted in issue 1725. So, in order to store that user preference, we need a new preference. This is added here, but its not yet hooked up in the app yet. This deals only with the preference handling. And adapted tests are included. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-10-08 14:15:53 +00:00
qPrefCloudStorage::set_cloud_auto_sync(true);
tests: add signal test to call testqPref*cpp Add signal testing of all variables this commit contains all qPref* that work directly followup commit will do changes to qPref* to make signals work Signed-off-by: Jan Iversen <jani@apache.org>
2018-08-28 10:33:47 +00:00
QCOMPARE(spy1.count(), 1);
QCOMPARE(spy2.count(), 1);
QCOMPARE(spy3.count(), 1);
QCOMPARE(spy4.count(), 1);
QCOMPARE(spy5.count(), 1);
QCOMPARE(spy6.count(), 1);
QCOMPARE(spy7.count(), 1);
QCOMPARE(spy9.count(), 1);
Prefs: add bool preference cloud_auto_sync [1/3] With removal of the git_local_only from the preferences (see ae653703a5d3f), the users choice, in the mobile app, was not stored any more in between sessions. This resulted in issue 1725. So, in order to store that user preference, we need a new preference. This is added here, but its not yet hooked up in the app yet. This deals only with the preference handling. And adapted tests are included. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-10-08 14:15:53 +00:00
QCOMPARE(spy10.count(), 1);
tests: add signal test to call testqPref*cpp Add signal testing of all variables this commit contains all qPref* that work directly followup commit will do changes to qPref* to make signals work Signed-off-by: Jan Iversen <jani@apache.org>
2018-08-28 10:33:47 +00:00
QVERIFY(spy1.takeFirst().at(0).toString() == "signal url");
QVERIFY(spy2.takeFirst().at(0).toString() == "signal myEmail");
QVERIFY(spy3.takeFirst().at(0).toString() == "signal encodedMyEMail");
QVERIFY(spy4.takeFirst().at(0).toString() == "signal more secret");
QVERIFY(spy5.takeFirst().at(0).toString() == "signal a pin");
QVERIFY(spy6.takeFirst().at(0).toInt() == 11);
QVERIFY(spy7.takeFirst().at(0).toInt() == qPrefCloudStorage::CS_VERIFIED);
QVERIFY(spy9.takeFirst().at(0).toBool() == true);
Prefs: add bool preference cloud_auto_sync [1/3] With removal of the git_local_only from the preferences (see ae653703a5d3f), the users choice, in the mobile app, was not stored any more in between sessions. This resulted in issue 1725. So, in order to store that user preference, we need a new preference. This is added here, but its not yet hooked up in the app yet. This deals only with the preference handling. And adapted tests are included. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-10-08 14:15:53 +00:00
QVERIFY(spy10.takeFirst().at(0).toBool() == true);
tests: add signal test to call testqPref*cpp Add signal testing of all variables this commit contains all qPref* that work directly followup commit will do changes to qPref* to make signals work Signed-off-by: Jan Iversen <jani@apache.org>
2018-08-28 10:33:47 +00:00
}
tests: add qPrefCloudStorage testcases add test cases to secure struct preferences and qPrefCloudStorage work together Signed-off-by: Jan Iversen <jani@apache.org>
2018-07-14 15:31:51 +00:00
QTEST_MAIN(TestQPrefCloudStorage)
Reference in a new issue Copy permalink