subsurface/core/imagedownloader.h

// SPDX-License-Identifier: GPL-2.0
#ifndef IMAGEDOWNLOADER_H
#define IMAGEDOWNLOADER_H

#include <QImage>
#include <QFuture>
#include <QNetworkReply>

class ImageDownloader : public QObject {
	Q_OBJECT
public:
	ImageDownloader(const QString &filename);
	void load(bool fromHash);

private:
	bool loadFromUrl(const QUrl &);	// return true on success
	void saveImage(QNetworkReply *reply, bool &success);
	QString filename;
};

QImage getHashedImage(const QString &filename);

#endif // IMAGEDOWNLOADER_H
Add SPDX header to remaining core files Signed-off-by: Dirk Hohndel <dirk@hohndel.org> 2017-04-27 20:24:53 +02:00			`// SPDX-License-Identifier: GPL-2.0`
Move ImageDownloader out of the desktop widgets This required a bit more untangling, but with this it seems we can build subsurface-mobile again (at least on the desktop). Interesting is the removal from inside the ImageDownloader of the call to DivePictureModel::instance()->updateDivePictures() - which actually could cause some interesting recursion issues. If it turns out we did indeed need this, it needs to be re-architected. Signed-off-by: Dirk Hohndel <dirk@hohndel.org> 2015-11-06 10:39:59 -08:00			`#ifndef IMAGEDOWNLOADER_H`
			`#define IMAGEDOWNLOADER_H`

			`#include <QImage>`
			`#include <QFuture>`
			`#include <QNetworkReply>`

			`class ImageDownloader : public QObject {`
Coding style: remove superfluous semicolons Remove a semicolon after Q_OBJECT and a few others after the closing braces of while loops. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at> 2018-03-06 10:38:21 +01:00			`Q_OBJECT`
Move ImageDownloader out of the desktop widgets This required a bit more untangling, but with this it seems we can build subsurface-mobile again (at least on the desktop). Interesting is the removal from inside the ImageDownloader of the call to DivePictureModel::instance()->updateDivePictures() - which actually could cause some interesting recursion issues. If it turns out we did indeed need this, it needs to be re-architected. Signed-off-by: Dirk Hohndel <dirk@hohndel.org> 2015-11-06 10:39:59 -08:00			`public:`
Dive pictures: replace picture struct by QString In imagedownloader.cpp the only thing we need from the picture struct is the filename. Therefore, use QStrings instead of the picture struct. This simplifies memory management. Remove the clone_picture() function, which is not needed anymore. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at> 2018-03-07 16:37:31 +01:00			`ImageDownloader(const QString &filename);`
If all else fails try loading images from cloud server Of course, as of this writing, there are no images on the server. In addition, this patch adds comments to explain the by now convoluted image retrieval logic (local file, filename as URL, by hash, cloud server). Signed-off-by: Robert C. Helling <helling@atdotde.de> Signed-off-by: Dirk Hohndel <dirk@hohndel.org> 2016-01-09 16:29:49 +01:00			`void load(bool fromHash);`
Move ImageDownloader out of the desktop widgets This required a bit more untangling, but with this it seems we can build subsurface-mobile again (at least on the desktop). Interesting is the removal from inside the ImageDownloader of the call to DivePictureModel::instance()->updateDivePictures() - which actually could cause some interesting recursion issues. If it turns out we did indeed need this, it needs to be re-architected. Signed-off-by: Dirk Hohndel <dirk@hohndel.org> 2015-11-06 10:39:59 -08:00
			`private:`
core/imagedownloader.cpp: remove recursion If loading from hash failed in the saveImage() slot(!) it would recurse into loadFromUrl(), which would generate a new network reply. Very scary and a (small) wonder that it worked. Let's try to make this all more explicit. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at> 2018-02-08 22:45:55 +01:00			`bool loadFromUrl(const QUrl &); // return true on success`
			`void saveImage(QNetworkReply *reply, bool &success);`
Dive pictures: replace picture struct by QString In imagedownloader.cpp the only thing we need from the picture struct is the filename. Therefore, use QStrings instead of the picture struct. This simplifies memory management. Remove the clone_picture() function, which is not needed anymore. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at> 2018-03-07 16:37:31 +01:00			`QString filename;`
Move ImageDownloader out of the desktop widgets This required a bit more untangling, but with this it seems we can build subsurface-mobile again (at least on the desktop). Interesting is the removal from inside the ImageDownloader of the call to DivePictureModel::instance()->updateDivePictures() - which actually could cause some interesting recursion issues. If it turns out we did indeed need this, it needs to be re-architected. Signed-off-by: Dirk Hohndel <dirk@hohndel.org> 2015-11-06 10:39:59 -08:00			`};`

Dive pictures: replace picture struct by QString In imagedownloader.cpp the only thing we need from the picture struct is the filename. Therefore, use QStrings instead of the picture struct. This simplifies memory management. Remove the clone_picture() function, which is not needed anymore. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at> 2018-03-07 16:37:31 +01:00			`QImage getHashedImage(const QString &filename);`
Move ImageDownloader out of the desktop widgets This required a bit more untangling, but with this it seems we can build subsurface-mobile again (at least on the desktop). Interesting is the removal from inside the ImageDownloader of the call to DivePictureModel::instance()->updateDivePictures() - which actually could cause some interesting recursion issues. If it turns out we did indeed need this, it needs to be re-architected. Signed-off-by: Dirk Hohndel <dirk@hohndel.org> 2015-11-06 10:39:59 -08:00
			`#endif // IMAGEDOWNLOADER_H`