subsurface/gettextfromc.h

#ifndef GETTEXTFROMC_H
#define GETTEXTFROMC_H

#include <QHash>

extern "C" const char *trGettext(const char *text);

class gettextFromC
{
Q_DECLARE_TR_FUNCTIONS(gettextFromC)
public:
	static gettextFromC *instance();
	const char *trGettext(const char *text);
	void reset(void);
	QHash <QByteArray , QByteArray> translationCache;
};

#endif // GETTEXTFROMC_H
Avoid the memory leaks from translations Instead use a hash to cache the translations (and allow for the ability to clear the hash so we can even switch translations at runtime...). Now Qt will keep track of the memory and release it for us when we are done with it. This avoids the memory leak introduced in commit 4ecb35bf5ff2 ("Make a copy of the translated text"). Signed-off-by: Dirk Hohndel <dirk@hohndel.org> 2013-10-09 05:44:38 +00:00			`#ifndef GETTEXTFROMC_H`
			`#define GETTEXTFROMC_H`
Trying to switch to Qt translation This compiles and looks about right, but it doesn't appear to work, yet. Signed-off-by: Dirk Hohndel <dirk@hohndel.org> 2013-10-06 15:55:58 +00:00
Avoid the memory leaks from translations Instead use a hash to cache the translations (and allow for the ability to clear the hash so we can even switch translations at runtime...). Now Qt will keep track of the memory and release it for us when we are done with it. This avoids the memory leak introduced in commit 4ecb35bf5ff2 ("Make a copy of the translated text"). Signed-off-by: Dirk Hohndel <dirk@hohndel.org> 2013-10-09 05:44:38 +00:00			`#include <QHash>`
Trying to switch to Qt translation This compiles and looks about right, but it doesn't appear to work, yet. Signed-off-by: Dirk Hohndel <dirk@hohndel.org> 2013-10-06 15:55:58 +00:00
Dismbiguate gettext Just to make sure there's no confusion - we are NOT calling gettext. We are calling tr from a gettext like interface. Signed-off-by: Dirk Hohndel <dirk@hohndel.org> 2013-10-10 07:15:21 +00:00			`extern "C" const char trGettext(const char text);`
Trying to switch to Qt translation This compiles and looks about right, but it doesn't appear to work, yet. Signed-off-by: Dirk Hohndel <dirk@hohndel.org> 2013-10-06 15:55:58 +00:00
			`class gettextFromC`
			`{`
			`Q_DECLARE_TR_FUNCTIONS(gettextFromC)`
			`public:`
			`static gettextFromC *instance();`
Dismbiguate gettext Just to make sure there's no confusion - we are NOT calling gettext. We are calling tr from a gettext like interface. Signed-off-by: Dirk Hohndel <dirk@hohndel.org> 2013-10-10 07:15:21 +00:00			`const char trGettext(const char text);`
Avoid the memory leaks from translations Instead use a hash to cache the translations (and allow for the ability to clear the hash so we can even switch translations at runtime...). Now Qt will keep track of the memory and release it for us when we are done with it. This avoids the memory leak introduced in commit 4ecb35bf5ff2 ("Make a copy of the translated text"). Signed-off-by: Dirk Hohndel <dirk@hohndel.org> 2013-10-09 05:44:38 +00:00			`void reset(void);`
change the key from const char * to QByteArray if trGettext() gets called with a text that resides in the stack, the QHash will return incorrect values after the second call of trGettext() with that text. Example (assuming nothing has been translated): void func(const char text) { char translated = trGettext(text); doSomethingWith(translated); } func("foo"); (1) func("bar"); (2) (1) translated is "foo" (2) translated should be "bar" but is "foo" because the key (const char*) points to the value "foo" which has been set in the previous call (1). Signed-off-by: Maximilian Güntner <maximilian.guentner@gmail.com> 2013-11-01 17:23:06 +00:00			`QHash <QByteArray , QByteArray> translationCache;`
Trying to switch to Qt translation This compiles and looks about right, but it doesn't appear to work, yet. Signed-off-by: Dirk Hohndel <dirk@hohndel.org> 2013-10-06 15:55:58 +00:00			`};`

Avoid the memory leaks from translations Instead use a hash to cache the translations (and allow for the ability to clear the hash so we can even switch translations at runtime...). Now Qt will keep track of the memory and release it for us when we are done with it. This avoids the memory leak introduced in commit 4ecb35bf5ff2 ("Make a copy of the translated text"). Signed-off-by: Dirk Hohndel <dirk@hohndel.org> 2013-10-09 05:44:38 +00:00			`#endif // GETTEXTFROMC_H`