mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

core: create qPrefDiveComputer from SettingsObjectWrapper

Browse source 
Update set/get functions to follow common name scheme:
- get function have same name as in struct diveComputer
- set function have set_<name>
- signal function have <name>_changed

one class one .h/.cpp is the C++ idiom. Having load/sync of each
variable in 1 functions (in contrast to the distributed way
SettingsObjectWrapper handles it) secures the same storage name
is used. Having the set/get/load/sync functions grouped together
makes it easier to get an overview.

REMARK: this commit only defines the class, it is not active in production

Signed-off-by: Jan Iversen <jani@apache.org>
This commit is contained in:
jan Iversen 2018-07-15 18:15:40 +02:00 • committed by Dirk Hohndel
parent 69c7ed676a
commit 0002cd2d20
6 changed files with 94 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

55
core/settings/qPrefDiveComputer.h Normal file
View file

@ -0,0 +1,55 @@
// SPDX-License-Identifier: GPL-2.0
#ifndef QPREFSDIVECOMPUTER_H
#define QPREFSDIVECOMPUTER_H
#include "core/pref.h"
#include <QObject>
class qPrefDiveComputer : public QObject {
Q_OBJECT
Q_PROPERTY(QString device READ device WRITE set_device NOTIFY device_changed);
Q_PROPERTY(QString device_name READ device_name WRITE set_device_name NOTIFY device_name_changed);
Q_PROPERTY(int download_mode READ download_mode WRITE set_download_mode NOTIFY download_mode_changed);
Q_PROPERTY(QString product READ product WRITE set_product NOTIFY product_changed);
Q_PROPERTY(QString vendor READ vendor WRITE set_vendor NOTIFY vendor_changed);
public:
qPrefDiveComputer(QObject *parent = NULL);
static qPrefDiveComputer *instance();
// Load/Sync local settings (disk) and struct preference
void loadSync(bool doSync);
void inline load() {loadSync(false); }
void inline sync() {loadSync(true); }
public:
static inline const QString& device() {return prefs.dive_computer.device; };
static inline const QString& device_name() {return prefs.dive_computer.device_name; };
static inline int download_mode() {return prefs.dive_computer.download_mode; };
static inline const QString& product() {return prefs.dive_computer.product; };
static inline const QString& vendor() {return prefs.dive_computer.vendor; };
public slots:
void set_device(const QString& device);
void set_device_name(const QString& device_name);
void set_download_mode(int mode);
void set_product(const QString& product);
void set_vendor(const QString& vendor);
signals:
void device_changed(const QString& device);
void device_name_changed(const QString& device_name);
void download_mode_changed(int mode);
void product_changed(const QString& product);
void vendor_changed(const QString& vendor);
private:
// functions to load/sync variable with disk
void disk_device(bool doSync);
void disk_device_name(bool doSync);
void disk_download_mode(bool doSync);
void disk_product(bool doSync);
void disk_vendor(bool doSync);
};
#endif