mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Planner: fix an enduring assert on startup

Browse source 
qt 5.3, win7 64bit.

beginRemoveRows() asserts in removeSelectedPoints()
because rowCount() - 1, becomes less than firstRow.

This needs a check in removeSelectedPoints() if the number
of passed rows is zero.

Signed-off-by: Lubomir I. Ivanov <neolit123@gmail.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Lubomir I. Ivanov 2014-07-20 16:18:00 +03:00 • committed by Dirk Hohndel
parent f6f2c4e929
commit 028568555f
1 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
qt-ui/diveplanner.cpp
View file

@ -53,6 +53,8 @@ bool intLessThan(int a, int b)
} }
void DivePlannerPointsModel::removeSelectedPoints(const QVector<int> &rows) void DivePlannerPointsModel::removeSelectedPoints(const QVector<int> &rows)
{ {
if (!rows.count())
return;
int firstRow = rowCount() - rows.count(); int firstRow = rowCount() - rows.count();
QVector<int> v2 = rows; QVector<int> v2 = rows;
std::sort(v2.begin(), v2.end(), intLessThan); std::sort(v2.begin(), v2.end(), intLessThan);