From 096de0efd01e12de6c4ce968eead90e95ff8157f Mon Sep 17 00:00:00 2001 From: Dirk Hohndel Date: Fri, 23 Jul 2021 11:27:49 -0700 Subject: [PATCH] core/import: fix string check logic The intent of the code was to check that there is a string and it has at least two characters. Since iter is the result of a strchr(iter, '|') call, we know that if iter isn't NULL, iter[0] is '|', so we only need to check the next character. Signed-off-by: Dirk Hohndel --- core/import-csv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/import-csv.c b/core/import-csv.c index 34ac1348b..84ab627c2 100644 --- a/core/import-csv.c +++ b/core/import-csv.c @@ -178,7 +178,7 @@ static int parse_dan_format(const char *filename, struct xml_params *params, str memset(tmpbuf, 0, sizeof(tmpbuf)); iter = strchr(iter, '|'); - if (iter && iter + 1) { + if (iter && iter[1]) { iter = iter + 1; iter_end = strchr(iter, '|');