mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2024-12-03 15:43:09 +00:00
Code Issues Projects Releases Packages Wiki Activity

Use QDir::exists() instead of QDir::setCurrent() to check for existence

Browse source 
Don't change into a directory just to see if it exists.
Remove unnecessary braces of one of the changed if statements.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2017-12-04 08:49:28 +01:00 committed by Lubomir I. Ivanov
parent ed92b60bfe
commit 0a2e53caf2
4 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
desktop-widgets/divelistview.cpp
View file

@ -1017,7 +1017,7 @@ QString DiveListView::lastUsedImageDir()
settings.beginGroup("FileDialog"); settings.beginGroup("FileDialog");
if (settings.contains("LastImageDir")) if (settings.contains("LastImageDir"))
if (QDir::setCurrent(settings.value("LastImageDir").toString())) if (QDir(settings.value("LastImageDir").toString()).exists())
lastImageDir = settings.value("LastImageDir").toString(); lastImageDir = settings.value("LastImageDir").toString();
return lastImageDir; return lastImageDir;
} }

3
desktop-widgets/divelogexportdialog.cpp
View file

@ -127,9 +127,8 @@ void DiveLogExportDialog::on_buttonBox_accepted()
settings.beginGroup("FileDialog"); settings.beginGroup("FileDialog");
if (settings.contains("LastDir")) { if (settings.contains("LastDir")) {
if (QDir::setCurrent(settings.value("LastDir").toString())) { if (QDir(settings.value("LastDir").toString()).exists())
lastDir = settings.value("LastDir").toString(); lastDir = settings.value("LastDir").toString();
}
} }
settings.endGroup(); settings.endGroup();

2
desktop-widgets/mainwindow.cpp
View file

@ -743,7 +743,7 @@ QString MainWindow::lastUsedDir()
settings.beginGroup("FileDialog"); settings.beginGroup("FileDialog");
if (settings.contains("LastDir")) if (settings.contains("LastDir"))
if (QDir::setCurrent(settings.value("LastDir").toString())) if (QDir(settings.value("LastDir").toString()).exists())
lastDir = settings.value("LastDir").toString(); lastDir = settings.value("LastDir").toString();
return lastDir; return lastDir;
} }

2
smtk-import/smrtk2ssrfc_window.cpp
View file

@ -34,7 +34,7 @@ QString Smrtk2ssrfcWindow::lastUsedDir()
settings.beginGroup("FileDialog"); settings.beginGroup("FileDialog");
if (settings.contains("LastDir")) if (settings.contains("LastDir"))
if (QDir::setCurrent(settings.value("LastDir").toString())) if (QDir(settings.value("LastDir").toString()).exists())
lastDir = settings.value("LastDir").toString(); lastDir = settings.value("LastDir").toString();
return lastDir; return lastDir;
} }