mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2024-12-11 19:41:30 +00:00
Code Issues Projects Releases Packages Wiki Activity

mobile/UI: move dive delete to context menu

Browse source 
Having this as the right action button (same one used for 'cancel' in
the edit screen) made it too likely to inadvertantly delete a dive. And
outside of testing, wanting to delete a dive really shouldn't be all
that common an operation. So remove the function from the action button
and place it into the context menu instead, right next to the undo
action so the user also is aware that there is an undo option.

Suggested-by: Peter Zaal <peter.zaal@gmail.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Dirk Hohndel 2021-01-17 11:29:22 -08:00
parent 1913e97bf2
commit 0a632e12d2
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
mobile-widgets/qml/DiveDetails.qml
View file

@ -115,7 +115,7 @@ Kirigami.Page {
enabled: manager.redoText !== "" enabled: manager.redoText !== ""
onTriggered: manager.redo() onTriggered: manager.redo()
} }
property variant contextactions: [ removeDiveFromTripAction, addDiveToTripAboveAction, addDiveToTripBelowAction, undoAction, redoAction ] property variant contextactions: [ removeDiveFromTripAction, addDiveToTripAboveAction, addDiveToTripBelowAction, deleteAction, undoAction, redoAction ]
states: [ states: [
State { State {
@ -123,7 +123,7 @@ Kirigami.Page {
PropertyChanges { PropertyChanges {
target: diveDetailsPage; target: diveDetailsPage;
actions { actions {
right: deleteAction right: null
left: currentItem ? (currentItem.modelData && currentItem.modelData.gps !== "" ? mapAction : null) : null left: currentItem ? (currentItem.modelData && currentItem.modelData.gps !== "" ? mapAction : null) : null
} }
contextualActions: contextactions contextualActions: contextactions