From 0a747608b1673eee9d134dc3cab57036768ef97f Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Sun, 6 Sep 2020 17:50:58 +0200 Subject: [PATCH] cleanup: remove dead code from delete_divecomputer() delete_divecomputer had legacy code, which 1) invalidated the git dive cache 2) made sure that the dive computer was not displayed anymore However, both callers called on a freshly copied dive, which has its dive cache invalidated in copy_dive() and can't be the currently displayed dive. Therefore, this code is dead code and can be removed. Signed-off-by: Berthold Stoeger --- core/dive.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/core/dive.c b/core/dive.c index ae468cf1d..1d16d3fe3 100644 --- a/core/dive.c +++ b/core/dive.c @@ -3560,12 +3560,6 @@ static void delete_divecomputer(struct dive *d, int num) free_dc(dc); } } - - /* If this is the currently displayed dive, we might have to adjust - * the currently displayed dive computer. */ - if (d == current_dive && dc_number >= number_of_computers(d)) - dc_number--; - invalidate_dive_cache(d); } /* Clone a dive and delete goven dive computer */