mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

cleanup: don't send values in changed-signals of ThemeInterface

Browse source 
According to the Qt-docs you *may* send the new values in the
NOTIFY signal of Q_PROPERTYs. However, since changes will lead
to a reevaluation of a whole expression, this argument will be
unused. All it does is make the code more verbose and brittle:
What happens if you send the wrong value?

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2020-03-30 21:20:49 +02:00 • committed by Dirk Hohndel
parent ce1629ccce
commit 0e9bd27bae
2 changed files with 37 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

36
mobile-widgets/themeinterface.h
View file

@ -44,26 +44,26 @@ public slots:
void set_currentScale(double);
signals:
void backgroundColorChanged(QColor);
void contrastAccentColorChanged(QColor);
void darkerPrimaryColorChanged(QColor);
void darkerPrimaryTextColorChanged(QColor);
void drawerColorChanged(QColor);
void lightDrawerColorChanged(QColor);
void lightPrimaryColorChanged(QColor);
void lightPrimaryTextColorChanged(QColor);
void primaryColorChanged(QColor);
void primaryTextColorChanged(QColor);
void secondaryTextColorChanged(QColor);
void textColorChanged(QColor);
void backgroundColorChanged();
void contrastAccentColorChanged();
void darkerPrimaryColorChanged();
void darkerPrimaryTextColorChanged();
void drawerColorChanged();
void lightDrawerColorChanged();
void lightPrimaryColorChanged();
void lightPrimaryTextColorChanged();
void primaryColorChanged();
void primaryTextColorChanged();
void secondaryTextColorChanged();
void textColorChanged();
void headingPointSizeChanged(double);
void regularPointSizeChanged(double);
void smallPointSizeChanged(double);
void titlePointSizeChanged(double);
void currentScaleChanged(double);
void headingPointSizeChanged();
void regularPointSizeChanged();
void smallPointSizeChanged();
void titlePointSizeChanged();
void currentScaleChanged();
void currentThemeChanged(const QString &);
void currentThemeChanged();
private:
ThemeInterface() {}