mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix off by one error

Browse source 
We increment i twice - which causes us to access memory past the end of
the allocated array.

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Dirk Hohndel 2012-12-07 20:01:05 -08:00
parent 407d4dd4aa
commit 0fcdd011f5
1 changed files with 0 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
gtk-gui.c
View file

@ -1592,7 +1592,6 @@ static int fill_computer_list(GtkListStore *vendorstore, GtkListStore ***product
dcl = dcl->next; dcl = dcl->next;
} }
/* now add the empty product list in case no vendor is selected */ /* now add the empty product list in case no vendor is selected */
i++;
pstores[i] = gtk_list_store_new(1, G_TYPE_POINTER); pstores[i] = gtk_list_store_new(1, G_TYPE_POINTER);
if (*product_index == -1) if (*product_index == -1)
*product_index = i; *product_index = i;