mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Cleanup: NULL check pointer before dereferencing

Browse source 
I we have no dive, whatever this is shouldn't be shown.

Found by Coverity. Fixes CID 350093

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Dirk Hohndel 2019-10-27 07:36:35 -04:00
parent 33137c62b0
commit 130946fcf4
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
qt-models/filtermodels.cpp
View file

@ -250,7 +250,7 @@ void MultiFilterSortModel::myInvalidate()
m->setData(idx, showTrip, DiveTripModelBase::SHOWN_ROLE); m->setData(idx, showTrip, DiveTripModelBase::SHOWN_ROLE);
} else { } else {
dive *d = m->data(idx, DiveTripModelBase::DIVE_ROLE).value<dive *>(); dive *d = m->data(idx, DiveTripModelBase::DIVE_ROLE).value<dive *>();
bool show = showDive(d); bool show = (d != NULL) && showDive(d);
if (show) if (show)
divesDisplayed++; divesDisplayed++;
m->setData(idx, show, DiveTripModelBase::SHOWN_ROLE); m->setData(idx, show, DiveTripModelBase::SHOWN_ROLE);