mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Remove superfluous QScopedPointer<>s in singletons

Browse source 
There was a curious pattern of singletons being implemented based on
QScopedPointer<>s. This is an unnecessary level of indirection:
The lifetime of the smart pointer is the same as that of the
pointed-to object. Therefore, replace these pointers by the respective
objects.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2017-12-20 20:00:26 +01:00 • committed by Dirk Hohndel
parent 4c4222d611
commit 130f109442
6 changed files with 12 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

4
qt-models/cylindermodel.cpp
View file

@ -31,8 +31,8 @@ QVariant CylindersModel::headerData(int section, Qt::Orientation orientation, in
CylindersModel *CylindersModel::instance()
{
static QScopedPointer<CylindersModel> self(new CylindersModel());
return self.data();
static CylindersModel self;
return &self;
}
static QString get_cylinder_string(cylinder_t *cyl)