mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Remove superfluous QScopedPointer<>s in singletons

Browse source 
There was a curious pattern of singletons being implemented based on
QScopedPointer<>s. This is an unnecessary level of indirection:
The lifetime of the smart pointer is the same as that of the
pointed-to object. Therefore, replace these pointers by the respective
objects.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2017-12-20 20:00:26 +01:00 • committed by Dirk Hohndel
parent 4c4222d611
commit 130f109442
6 changed files with 12 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

4
qt-models/models.cpp
View file

@ -32,8 +32,8 @@ Qt::ItemFlags GasSelectionModel::flags(const QModelIndex &index) const
GasSelectionModel *GasSelectionModel::instance()
{
static QScopedPointer<GasSelectionModel> self(new GasSelectionModel());
return self.data();
static GasSelectionModel self;
return &self;
}
//TODO: Remove this #include here when the issue below is fixed.