mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Mobile: fix bound check in DiveListModel::data()

Browse source 
Indexes go from 0 to count - 1. Thus, the comparison for invalid
indexes has to read ">= count", not "> count".

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2019-08-13 08:08:34 +02:00 • committed by Dirk Hohndel
parent 62cbfc3325
commit 14dd93b655
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
qt-models/divelistmodel.cpp
View file

@ -238,7 +238,7 @@ int DiveListModel::getDiveIdx(int id) const
QVariant DiveListModel::data(const QModelIndex &index, int role) const QVariant DiveListModel::data(const QModelIndex &index, int role) const
{ {
if(index.row() < 0 || index.row() > m_dives.count()) if(index.row() < 0 || index.row() >= m_dives.count())
return QVariant(); return QVariant();
DiveObjectHelper *curr_dive = m_dives[index.row()]; DiveObjectHelper *curr_dive = m_dives[index.row()];