mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

cleanup: break out the dive-notes tab

Browse source 
There was always this weird asymmetry that the "maintab" widget
is one of the tabs itself, whereas the additional tabs were
treated as extra-widgets. Turn the first tab into explicit
source files to make the distinction between container and
content clear.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2022-03-05 17:25:49 +01:00
parent 2657ec9016
commit 152016d293
9 changed files with 1025 additions and 965 deletions
Download patch file Download diff file Expand all files Collapse all files

34
desktop-widgets/tab-widgets/maintab.h
View file

@ -11,14 +11,9 @@
#include <QTabWidget>
#include "ui_maintab.h"
#include "qt-models/completionmodels.h"
#include "qt-models/divelocationmodel.h"
#include "core/dive.h"
#include "core/subsurface-qt/divelistnotifier.h"
class ExtraDataModel;
class DivePictureModel;
class TabBase;
class MainTab : public QTabWidget {
Q_OBJECT
@ -30,42 +25,15 @@ public:
public
slots:
void divesChanged(const QVector<dive *> &dives, DiveField field);
void diveSiteEdited(dive_site *ds, int field);
void tripChanged(dive_trip *trip, TripField field);
void updateDiveInfo();
void updateNotes(const struct dive *d);
void updateDateTime(const struct dive *d);
void updateTripDate(const struct dive_trip *t);
void updateDiveSite(struct dive *d);
void on_location_diveSiteSelected();
void on_locationPopupButton_clicked();
void on_diveguide_editingFinished();
void on_buddy_editingFinished();
void on_diveTripLocation_editingFinished();
void on_notes_editingFinished();
void on_duration_editingFinished();
void on_depth_editingFinished();
void on_dateEdit_editingFinished();
void on_timeEdit_editingFinished();
void on_rating_valueChanged(int value);
void on_tagWidget_editingFinished();
void closeWarning();
void escDetected(void);
void updateDateTimeFields();
void escDetected();
void colorsChanged();
private:
Ui::MainTab ui;
bool ignoreInput; // When computionally editing fields, we have to ignore changed-signals
BuddyCompletionModel buddyModel;
DiveGuideCompletionModel diveGuideModel;
TagCompletionModel tagModel;
bool lastSelectedDive;
int lastTabSelectedDive;
int lastTabSelectedDiveTrip;
dive_trip *currentTrip;
QList<TabBase*> extraWidgets;
void divesEdited(int num); // Opens a warning window if more than one dive was edited
void changeEvent(QEvent *ev) override;
bool isDark;
};