From 1777df405fef2b5ebd7be0de6bdc9084df959d28 Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Fri, 15 May 2020 10:06:50 +0200 Subject: [PATCH] desktop: don't call plotDive with doClearPictures = true This was an old "optimization" to avoid double plotting of the pictures, first by the profile itself, then by the picture tab. Since the profile now updates the pictures itself, this must be removed: The picture tab doesn't do it anymore. Fixes #2833 Signed-off-by: Berthold Stoeger --- CHANGELOG.md | 1 + desktop-widgets/mainwindow.cpp | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 16878525f..482e55a60 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,4 @@ +Desktop: fix plotting of thumbnails on profile [#2833] Core: always include BT/BLE name, even for devices no recognized as dive computer Core: fix failure to recognize several Aqualung BLE dive computers Mobile: show dive tags on dive details page diff --git a/desktop-widgets/mainwindow.cpp b/desktop-widgets/mainwindow.cpp index 7888a1d48..b3f474de8 100644 --- a/desktop-widgets/mainwindow.cpp +++ b/desktop-widgets/mainwindow.cpp @@ -449,7 +449,7 @@ void MainWindow::selectionChanged() configureToolbar(); enableDisableOtherDCsActions(); } - graphics->plotDive(current_dive, false, true); + graphics->plotDive(current_dive, false); MapWidget::instance()->selectionChanged(); } @@ -1080,7 +1080,7 @@ void MainWindow::on_actionPreviousDC_triggered() unsigned nrdc = number_of_computers(current_dive); dc_number = (dc_number + nrdc - 1) % nrdc; configureToolbar(); - graphics->plotDive(current_dive, false, true); + graphics->plotDive(current_dive, false); mainTab->updateDiveInfo(); } @@ -1089,7 +1089,7 @@ void MainWindow::on_actionNextDC_triggered() unsigned nrdc = number_of_computers(current_dive); dc_number = (dc_number + 1) % nrdc; configureToolbar(); - graphics->plotDive(current_dive, false, true); + graphics->plotDive(current_dive, false); mainTab->updateDiveInfo(); }