diff --git a/Subsurface-mobile.pro b/Subsurface-mobile.pro index 5846536ff..b604f4858 100644 --- a/Subsurface-mobile.pro +++ b/Subsurface-mobile.pro @@ -75,7 +75,7 @@ SOURCES += subsurface-mobile-main.cpp \ core/import-csv.cpp \ core/save-html.c \ core/statistics.c \ - core/worldmap-save.c \ + core/worldmap-save.cpp \ core/libdivecomputer.cpp \ core/version.c \ core/save-git.cpp \ diff --git a/core/CMakeLists.txt b/core/CMakeLists.txt index 88e1ea312..5e07de60c 100644 --- a/core/CMakeLists.txt +++ b/core/CMakeLists.txt @@ -203,7 +203,7 @@ set(SUBSURFACE_CORE_LIB_SRCS windowtitleupdate.cpp windowtitleupdate.h worldmap-options.h - worldmap-save.c + worldmap-save.cpp worldmap-save.h xmlparams.cpp xmlparams.h diff --git a/core/worldmap-save.c b/core/worldmap-save.cpp similarity index 73% rename from core/worldmap-save.c rename to core/worldmap-save.cpp index 61c223442..5f3804a36 100644 --- a/core/worldmap-save.c +++ b/core/worldmap-save.cpp @@ -15,21 +15,22 @@ #include "errorhelper.h" #include "file.h" #include "save-html.h" +#include "subsurface-string.h" #include "worldmap-save.h" #include "worldmap-options.h" #include "gettext.h" -char *getGoogleApi() +static const char *getGoogleApi() { /* google maps api auth*/ return "https://maps.googleapis.com/maps/api/js?"; } -void writeMarkers(struct membuffer *b, bool selected_only) +static void writeMarkers(struct membuffer *b, bool selected_only) { int i, dive_no = 0; struct dive *dive; - char pre[1000], post[1000]; + std::string pre, post; for_each_dive (i, dive) { if (selected_only) { @@ -42,13 +43,13 @@ void writeMarkers(struct membuffer *b, bool selected_only) put_degrees(b, ds->location.lat, "temp = new google.maps.Marker({position: new google.maps.LatLng(", ""); put_degrees(b, ds->location.lon, ",", ")});\n"); put_string(b, "markers.push(temp);\ntempinfowindow = new google.maps.InfoWindow({content: '
'+'
'+'
'+'
"); - snprintf(pre, sizeof(pre), "

%s ", translate("gettextFromC", "Date:")); - put_HTML_date(b, dive, pre, "

"); - snprintf(pre, sizeof(pre), "

%s ", translate("gettextFromC", "Time:")); - put_HTML_time(b, dive, pre, "

"); - snprintf(pre, sizeof(pre), "

%s ", translate("gettextFromC", "Duration:")); - snprintf(post, sizeof(post), " %s

", translate("gettextFromC", "min")); - put_duration(b, dive->duration, pre, post); + pre = format_string_std("

%s ", translate("gettextFromC", "Date:")); + put_HTML_date(b, dive, pre.c_str(), "

"); + pre = format_string_std("

%s ", translate("gettextFromC", "Time:")); + put_HTML_time(b, dive, pre.c_str(), "

"); + pre = format_string_std("

%s ", translate("gettextFromC", "Duration:")); + post = format_string_std(" %s

", translate("gettextFromC", "min")); + put_duration(b, dive->duration, pre.c_str(), post.c_str()); put_string(b, "

"); put_HTML_quoted(b, translate("gettextFromC", "Max. depth:")); put_HTML_depth(b, dive, " ", "

"); @@ -58,12 +59,12 @@ void writeMarkers(struct membuffer *b, bool selected_only) put_string(b, "

"); put_HTML_quoted(b, translate("gettextFromC", "Water temp.:")); put_HTML_watertemp(b, dive, " ", "

"); - snprintf(pre, sizeof(pre), "

%s ", translate("gettextFromC", "Location:")); - put_string(b, pre); + pre = format_string_std("

%s ", translate("gettextFromC", "Location:")); + put_string(b, pre.c_str()); put_HTML_quoted(b, get_dive_location(dive)); put_string(b, "

"); - snprintf(pre, sizeof(pre), "

%s ", translate("gettextFromC", "Notes:")); - put_HTML_notes(b, dive, pre, "

"); + pre = format_string_std("

%s ", translate("gettextFromC", "Notes:")); + put_HTML_notes(b, dive, pre.c_str(), "

"); put_string(b, "

'+'
'+'
'});\ninfowindows.push(tempinfowindow);\n"); put_format(b, "google.maps.event.addListener(markers[%d], 'mouseover', function() {\ninfowindows[%d].open(map,markers[%d]);}", dive_no, dive_no, dive_no); put_format(b, ");google.maps.event.addListener(markers[%d], 'mouseout', function() {\ninfowindows[%d].close();});\n", dive_no, dive_no); @@ -71,19 +72,19 @@ void writeMarkers(struct membuffer *b, bool selected_only) } } -void insert_html_header(struct membuffer *b) +static void insert_html_header(struct membuffer *b) { put_string(b, "\n\n\n"); put_string(b, "\nWorld Map\n"); put_string(b, ""); } -void insert_css(struct membuffer *b) +static void insert_css(struct membuffer *b) { put_format(b, "\n", css); } -void insert_javascript(struct membuffer *b, const bool selected_only) +static void insert_javascript(struct membuffer *b, const bool selected_only) { put_string(b, "