From 194d4b4c00a783e5c4300e32d07ed963d493211d Mon Sep 17 00:00:00 2001 From: Miika Turkia Date: Tue, 2 Dec 2014 05:59:57 +0200 Subject: [PATCH] Variable should be declared before loop Fixing incorrect variable scope. (I do not really see any functional differences on Firefox, but better declare the variable before the loop.) Signed-off-by: Miika Turkia Signed-off-by: Dirk Hohndel --- theme/list_lib.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/theme/list_lib.js b/theme/list_lib.js index e50fc3912..6fde5417c 100644 --- a/theme/list_lib.js +++ b/theme/list_lib.js @@ -431,10 +431,12 @@ function sort_it(sortOn, function_) for (var j = 0; j < itemsToShow.length; j++) { visited[j] = false; } + + var iSmaller; for (var i = 0; i < itemsToShow.length; i++) { for (var j = 0; j < itemsToShow.length; j++) if (visited[j] === false) - var iSmaller = j; + iSmaller = j; for (var j = 0; j < itemsToShow.length; j++) { if (function_(itemsToShow[j], itemsToShow[iSmaller])) { if (visited[j] === false) {