mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-01-19 14:25:27 +00:00
Code Issues Projects Releases Packages Wiki Activity

Cleanup: avoid memory leak

Browse source 
Coverity CID 208327

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Dirk Hohndel 2017-12-26 14:22:52 -08:00
parent 42db44510d
commit 1a46f5eb9b
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
core/liquivision.c
View file

@ -427,6 +427,7 @@ static void parse_dives (int log_version, const unsigned char *buf, unsigned int
// End dive // End dive
dive->downloaded = true; dive->downloaded = true;
record_dive(dive); record_dive(dive);
dive = NULL;
mark_divelist_changed(true); mark_divelist_changed(true);
// Advance ptr for next dive // Advance ptr for next dive
@ -434,6 +435,9 @@ static void parse_dives (int log_version, const unsigned char *buf, unsigned int
} // while } // while
//DEBUG save_dives("/tmp/test.xml"); //DEBUG save_dives("/tmp/test.xml");
// if we bailed out of the loop, the dive hasn't been recorded and dive hasn't been set to NULL
free(dive);
} }
int try_to_open_liquivision(const char *filename, struct memblock *mem) int try_to_open_liquivision(const char *filename, struct memblock *mem)