mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Settings update: Fix broken UpdateManger logic

Browse source 
In commit b76c1846bb ("Settings update: Simplify Update Manager")
the logic for when to show the UpdateManger question to the user got
broken. Unintuitively, a boolean setting actually has three possible
values. True, False, and Unset. This patch fixes things to work as
designed again.

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Dirk Hohndel 2016-08-27 12:26:13 -07:00
parent f745a25cb7
commit 1bf76dd3db
4 changed files with 10 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
desktop-widgets/updatemanager.cpp
View file

@ -110,7 +110,7 @@ void UpdateManager::requestReceived()
}
if (isAutomaticCheck) {
auto update_settings = SettingsObjectWrapper::instance()->update_manager_settings;
if (!update_settings->dontCheckForUpdates()) {
if (!update_settings->dontCheckExists()) {
// we allow an opt out of future checks
QMessageBox response(MainWindow::instance());