mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Cleanup: remove all override modifiers

Browse source 
Commit df156a56c0 replaced "virtual"
by "override" where appropriate. Unfortunately, this had the
unintended consequence of producing numerous clang warnings. If
clang finds a override-modified function in a class definition,
it warns for *all* overriden virtual functions without the override
modifier.

To solve this, go the easy route and remove all overrides. At least
it is consistent.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2018-08-01 11:01:26 +02:00 • committed by Dirk Hohndel
parent 42aae8196f
commit 1c4a859c8d
49 changed files with 199 additions and 199 deletions
Download patch file Download diff file Expand all files Collapse all files

6
desktop-widgets/subsurfacewebservices.h
View file

@ -105,9 +105,9 @@ public:
private
slots:
// need to declare them as no ops or Qt4 is unhappy
void startDownload() override { }
void startUpload() override { }
void buttonClicked(QAbstractButton *button) override { Q_UNUSED(button) }
void startDownload() { }
void startUpload() { }
void buttonClicked(QAbstractButton *button) { Q_UNUSED(button) }
};
#endif // SUBSURFACEWEBSERVICES_H