mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

cleanup: free tab-widgets when exiting the application

Browse source 
This is completely irrelevant, however out of principle,
let's free the tab-widgets at the end of the application.
To do so, use Qt's object hierarchy. I'm not a fan of this
kind of memory management, but it is how it is.

Moreover, remove the explicit constructor of MainTab, since
it doesn't differ from the default constructor anyway.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Berthold Stoeger 2020-04-13 19:26:29 +02:00 • committed by Dirk Hohndel
parent c139c16c03
commit 1c590783e0
2 changed files with 6 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

16
desktop-widgets/tab-widgets/maintab.cpp
View file

@ -58,17 +58,17 @@ MainTab::MainTab(QWidget *parent) : QTabWidget(parent),
{ {
ui.setupUi(this); ui.setupUi(this);
extraWidgets << new TabDiveEquipment(); extraWidgets << new TabDiveEquipment(this);
ui.tabWidget->addTab(extraWidgets.last(), tr("Equipment")); ui.tabWidget->addTab(extraWidgets.last(), tr("Equipment"));
extraWidgets << new TabDiveInformation(); extraWidgets << new TabDiveInformation(this);
ui.tabWidget->addTab(extraWidgets.last(), tr("Information")); ui.tabWidget->addTab(extraWidgets.last(), tr("Information"));
extraWidgets << new TabDiveStatistics(); extraWidgets << new TabDiveStatistics(this);
ui.tabWidget->addTab(extraWidgets.last(), tr("Statistics")); ui.tabWidget->addTab(extraWidgets.last(), tr("Statistics"));
extraWidgets << new TabDivePhotos(); extraWidgets << new TabDivePhotos(this);
ui.tabWidget->addTab(extraWidgets.last(), tr("Media")); ui.tabWidget->addTab(extraWidgets.last(), tr("Media"));
extraWidgets << new TabDiveExtraInfo(); extraWidgets << new TabDiveExtraInfo(this);
ui.tabWidget->addTab(extraWidgets.last(), tr("Extra Info")); ui.tabWidget->addTab(extraWidgets.last(), tr("Extra Info"));
extraWidgets << new TabDiveSite(); extraWidgets << new TabDiveSite(this);
ui.tabWidget->addTab(extraWidgets.last(), tr("Dive sites")); ui.tabWidget->addTab(extraWidgets.last(), tr("Dive sites"));
ui.dateEdit->setDisplayFormat(prefs.date_format); ui.dateEdit->setDisplayFormat(prefs.date_format);
@ -178,10 +178,6 @@ MainTab::MainTab(QWidget *parent) : QTabWidget(parent),
ui.diveTripLocation->hide(); ui.diveTripLocation->hide();
} }
MainTab::~MainTab()
{
}
void MainTab::hideMessage() void MainTab::hideMessage()
{ {
ui.diveNotesMessage->animatedHide(); ui.diveNotesMessage->animatedHide();

1
desktop-widgets/tab-widgets/maintab.h
View file

@ -27,7 +27,6 @@ class MainTab : public QTabWidget {
Q_OBJECT Q_OBJECT
public: public:
MainTab(QWidget *parent = 0); MainTab(QWidget *parent = 0);
~MainTab();
void clearTabs(); void clearTabs();
void reload(); void reload();
void initialUiSetup(); void initialUiSetup();