tests: add qPrefDisplay testcases

remove test macro, split in functions and add test cases

the existing test macro does not work because
sync() does not save these variables to disk (set* does)

Signed-off-by: Jan Iversen <jani@apache.org>
This commit is contained in:
jan Iversen 2018-07-06 15:10:22 +02:00
parent 8f7f1cacd6
commit 1ef3f61cc9
2 changed files with 115 additions and 21 deletions

View file

@ -2,16 +2,11 @@
#include "testqPrefDisplay.h" #include "testqPrefDisplay.h"
#include "core/settings/qPrefDisplay.h" #include "core/settings/qPrefDisplay.h"
#include "core/pref.h"
#include "core/qthelper.h"
#include <QtTest>
#include <QDate> #include <QDate>
#define TEST(METHOD, VALUE) \
QCOMPARE(METHOD, VALUE); \
display->sync(); \
display->load(); \
QCOMPARE(METHOD, VALUE);
void TestQPrefDisplay::initTestCase() void TestQPrefDisplay::initTestCase()
{ {
QCoreApplication::setOrganizationName("Subsurface"); QCoreApplication::setOrganizationName("Subsurface");
@ -19,24 +14,120 @@ void TestQPrefDisplay::initTestCase()
QCoreApplication::setApplicationName("SubsurfaceTestQPrefDisplay"); QCoreApplication::setApplicationName("SubsurfaceTestQPrefDisplay");
} }
void TestQPrefDisplay::test1() void TestQPrefDisplay::test_struct_get()
{ {
// Test struct pref -> get func.
auto display = qPrefDisplay::instance(); auto display = qPrefDisplay::instance();
display->set_divelist_font("comic");
display->set_font_size(10.0); prefs.display_invalid_dives = true;
prefs.divelist_font = copy_qstring("comic");
prefs.font_size = 12.0;
prefs.show_developer = false;
prefs.theme = copy_qstring("myTheme");
QCOMPARE(display->display_invalid_dives(), prefs.display_invalid_dives);
QCOMPARE(display->divelist_font(), QString(prefs.divelist_font));
QCOMPARE(display->font_size(), prefs.font_size);
QCOMPARE(display->show_developer(), prefs.show_developer);
QCOMPARE(display->theme(), QString(prefs.theme));
}
void TestQPrefDisplay::test_set_struct()
{
// Test set func -> struct pref
auto display = qPrefDisplay::instance();
display->set_display_invalid_dives(true); display->set_display_invalid_dives(true);
display->set_divelist_font("comic");
display->set_font_size(12.0);
display->set_show_developer(false);
display->set_theme("myTheme");
TEST(display->divelist_font(),QStringLiteral("comic")); QCOMPARE(prefs.display_invalid_dives, true);
TEST(display->font_size(), 10.0); QCOMPARE(prefs.divelist_font, "comic");
TEST(display->display_invalid_dives(), true); QCOMPARE(prefs.font_size, 12.0);
QCOMPARE(prefs.show_developer, false);
QCOMPARE(prefs.theme, "myTheme");
}
void TestQPrefDisplay::test_set_load_struct()
{
// test set func -> load -> struct pref
auto display = qPrefDisplay::instance();
display->set_divelist_font("helvetica");
display->set_font_size(14.0);
display->set_display_invalid_dives(false); display->set_display_invalid_dives(false);
display->set_divelist_font("helvitica");
display->set_font_size(15.0);
display->set_show_developer(true);
display->set_theme("myTheme2");
TEST(display->divelist_font(),QStringLiteral("helvetica")); prefs.display_invalid_dives = true;
TEST(display->font_size(), 14.0); prefs.divelist_font = copy_qstring("comic");
TEST(display->display_invalid_dives(), false); prefs.font_size = 12.0;
prefs.show_developer = false;
prefs.theme = copy_qstring("myTheme");
display->load();
QCOMPARE(prefs.display_invalid_dives, false);
QCOMPARE(prefs.divelist_font, "helvitica");
QCOMPARE(prefs.font_size, 15.0);
QCOMPARE(prefs.show_developer, true);
QCOMPARE(prefs.theme, "myTheme2");
}
void TestQPrefDisplay::test_struct_disk()
{
// test struct prefs -> disk
auto display = qPrefDisplay::instance();
prefs.display_invalid_dives = true;
prefs.divelist_font = copy_qstring("helvitica");
prefs.font_size = 17.0;
prefs.show_developer = false;
prefs.theme = copy_qstring("myTheme3");
display->sync();
prefs.display_invalid_dives = false;
prefs.divelist_font = copy_qstring("comic");
prefs.font_size = 11.0;
prefs.show_developer = true;
prefs.theme = copy_qstring("myTheme");
display->load();
QCOMPARE(prefs.display_invalid_dives, true);
QCOMPARE(prefs.divelist_font, "helvitica");
QCOMPARE(prefs.font_size, 17.0);
QCOMPARE(prefs.show_developer, false);
QCOMPARE(prefs.theme, "myTheme3");
}
void TestQPrefDisplay::test_multiple()
{
// test multiple instances have the same information
prefs.display_invalid_dives = false;
prefs.divelist_font = copy_qstring("comic");
prefs.font_size = 11.0;
prefs.show_developer = true;
prefs.theme = copy_qstring("myTheme");
auto display_direct = new qPrefDisplay;
prefs.display_invalid_dives = true;
prefs.divelist_font = copy_qstring("helvetica");
prefs.font_size = 15.0;
prefs.show_developer = false;
prefs.theme = copy_qstring("myTheme8");
auto display = qPrefDisplay::instance();
QCOMPARE(display->display_invalid_dives(), display_direct->display_invalid_dives());
QCOMPARE(display->divelist_font(), display_direct->divelist_font());
QCOMPARE(display->font_size(), display_direct->font_size());
QCOMPARE(display->show_developer(), display_direct->show_developer());
QCOMPARE(display->theme(), display_direct->theme());
} }
QTEST_MAIN(TestQPrefDisplay) QTEST_MAIN(TestQPrefDisplay)

View file

@ -2,15 +2,18 @@
#ifndef TESTQPREFDISPLAY_H #ifndef TESTQPREFDISPLAY_H
#define TESTQPREFDISPLAY_H #define TESTQPREFDISPLAY_H
#include <QTest> #include <QtTest>
#include <functional>
class TestQPrefDisplay : public QObject class TestQPrefDisplay : public QObject
{ {
Q_OBJECT Q_OBJECT
private slots: private slots:
void initTestCase(); void initTestCase();
void test1(); void test_struct_get();
void test_set_struct();
void test_set_load_struct();
void test_struct_disk();
void test_multiple();
}; };
#endif // TESTQPREFDISPLAY_H #endif // TESTQPREFDISPLAY_H