mirror of
https://github.com/subsurface/subsurface.git
synced 2025-02-19 22:16:15 +00:00
Break down MainTab into smaller classes
Maintab is one of our most complex classes, and it's something I'm not actually proud of. But it currently works and the idea of splitting it was in my head for quite a while. This is the third or fourth tentative of splitting it, and this time I let the most complex part of it untouched, the Notes and Equipment tab are way too complex to untangle right now on my limited time. A new class 'TabBase' should be used for any new tab that we may create, and added on the MainTab (see the new lines on the MainTab constructor). Also, Extra Info, Information, Photos and Statistics where ported to this new way helping reduce the number of lines and functions on the MainTab quite a bit. Overall this is a step in the right direction for the future. Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
parent
8a71196e4e
commit
1fc4fba69f
23 changed files with 1152 additions and 886 deletions
17
desktop-widgets/tab-widgets/TabBase.h
Normal file
17
desktop-widgets/tab-widgets/TabBase.h
Normal file
|
@ -0,0 +1,17 @@
|
|||
#ifndef TAB_BASE_H
|
||||
#define TAB_BASE_H
|
||||
|
||||
#include <QWidget>
|
||||
|
||||
struct dive;
|
||||
|
||||
class TabBase : public QWidget {
|
||||
Q_OBJECT
|
||||
|
||||
public:
|
||||
TabBase(QWidget *parent);
|
||||
virtual void updateData() = 0;
|
||||
virtual void clear() = 0;
|
||||
};
|
||||
|
||||
#endif
|
Loading…
Add table
Add a link
Reference in a new issue