Make the default preferences explicit

This makes it explicit what the default preferences are, so that we can
more easily avoid unnecessarily saving default settings.  It also makes
imperial metrics the default for the US (Burma and Liberia always get
forgotten!)

Right now we tend to be somewhat confused about defaults.  We do have
them, but then even if something has a default value, we tend to write
it out to the config file.  Which is not just unnecessary, but makes it
really hard to see after-the-fact whether the user actually wanted that
*specific* value, or whether they just wanted the default behavior.

So this prepares for having explicit configuration for when we want
something different than the defaults.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Linus Torvalds 2013-01-10 17:55:44 -08:00 committed by Dirk Hohndel
parent 868a2cc090
commit 21f38190d3
2 changed files with 51 additions and 9 deletions

View file

@ -35,13 +35,6 @@ const char *existing_filename;
const char *divelist_font;
const char *default_filename;
struct preferences prefs = {
SI_UNITS,
{ TRUE, FALSE, },
{ FALSE, FALSE, FALSE, 1.6, 4.0, 13.0},
FALSE, FALSE, FALSE, 0.30, 0.75
};
char *nicknamestring;
static GtkWidget *dive_profile;