From 221b5f0ff7eb63efb22da9768a70994c9bb88c0e Mon Sep 17 00:00:00 2001 From: Anton Lundin Date: Tue, 30 Dec 2014 00:25:56 +0100 Subject: [PATCH] Only check for update after successfull download We check that the logbook download didn't error out before checking if we should remind the user to upgrade the firmware. Otherwise we will check if whatever the current firmware version is, is greater than zero and always remind the user to upgrade the fw. Signed-off-by: Anton Lundin Signed-off-by: Dirk Hohndel --- qt-ui/downloadfromdivecomputer.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qt-ui/downloadfromdivecomputer.cpp b/qt-ui/downloadfromdivecomputer.cpp index a356a767a..7f5fd4a46 100644 --- a/qt-ui/downloadfromdivecomputer.cpp +++ b/qt-ui/downloadfromdivecomputer.cpp @@ -403,7 +403,7 @@ void DownloadFromDCWidget::onDownloadThreadFinished() MainWindow::instance()->dive_list()->unselectDives(); MainWindow::instance()->dive_list()->selectDive(idx, true); QString dcName = data.devname; - if (ostcFirmwareCheck) + if (ostcFirmwareCheck && currentState == DONE) ostcFirmwareCheck->checkLatest(this, &data); } } else if (currentState == CANCELLING || currentState == CANCELLED) {