mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Edit the name of the Dive Computer via dialog.

Browse source 
The GTK version seems to be bugged on this, since the dialog
doesn't save the dive computer nickname that I setted, but
the Qt version shows less dive-computers than the GTK one on the
same dive. I want somebody to do a quick review of my code too. :)

I also plan to remove the 'OK' and 'Cancel' buttom, they seem to
be overrated on this dialog - fairly uneeded.

Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org>
This commit is contained in:
Tomaz Canabrava 2013-06-07 12:57:35 -03:00
parent ebed836ee5
commit 24446f9c3c
2 changed files with 23 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
qt-ui/models.cpp
View file

@ -1173,18 +1173,35 @@ void DiveComputerModel::update()
nnl = nnl->next; nnl = nnl->next;
count++; count++;
} }
qDebug() << "Numero de Devices" << count;
if(numRows){ if(numRows){
beginRemoveRows(QModelIndex(), 0, numRows-1); beginRemoveRows(QModelIndex(), 0, numRows-1);
numRows = 0; numRows = 0;
endRemoveRows(); endRemoveRows();
} }
if (count){ if (count){
beginInsertRows(QModelIndex(), 0, count-1); beginInsertRows(QModelIndex(), 0, count-1);
numRows = count; numRows = count;
endInsertRows(); endInsertRows();
} }
}
Qt::ItemFlags DiveComputerModel::flags(const QModelIndex& index) const
{
Qt::ItemFlags flags = QAbstractItemModel::flags(index);
if (index.column() == NICKNAME)
flags |= Qt::ItemIsEditable;
return flags;
}
bool DiveComputerModel::setData(const QModelIndex& index, const QVariant& value, int role)
{
struct device_info *nnl = head_of_device_info_list();
for(int i = 0; i < index.row(); i++){
nnl = nnl->next;
}
QByteArray v = value.toByteArray();
nnl->nickname = strdup(v.data()); // how should I free this before setting a new one?
} }

2
qt-ui/models.h
View file

@ -177,6 +177,8 @@ public:
virtual int columnCount(const QModelIndex& parent = QModelIndex()) const; virtual int columnCount(const QModelIndex& parent = QModelIndex()) const;
virtual QVariant data(const QModelIndex& index, int role = Qt::DisplayRole) const; virtual QVariant data(const QModelIndex& index, int role = Qt::DisplayRole) const;
virtual int rowCount(const QModelIndex& parent = QModelIndex()) const; virtual int rowCount(const QModelIndex& parent = QModelIndex()) const;
virtual Qt::ItemFlags flags(const QModelIndex& index) const;
virtual bool setData(const QModelIndex& index, const QVariant& value, int role = Qt::EditRole);
void update(); void update();
private: private:
int numRows; int numRows;