mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Filter: prevent selection-change notifications in filter invalidation

Browse source 
Invalidating the filter can cause numerous selection-change notifications.
These cause a full UI reload. Therefore, go into "command" mode that was
implemented for the undo commands. Then, all selection-changes are
considered as "programmatical" and ignored.

At the end of filter invalidation, a filter-finished signal causes a
proper reload anyway.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2019-05-06 22:52:52 +02:00 • committed by Dirk Hohndel
parent 4e81edcf1e
commit 29c6aea797
1 changed files with 24 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

36
qt-models/filtermodels.cpp
View file

@ -227,21 +227,33 @@ void MultiFilterSortModel::myInvalidate()
int i; int i;
struct dive *d; struct dive *d;
divesDisplayed = 0; {
// This marker prevents the UI from getting notifications on selection changes.
// It is active until the end of the scope.
// This is actually meant for the undo-commands, so that they can do their work
// without having the UI updated.
// Here, it is used because invalidating the filter can generate numerous
// selection changes, which do full ui reloads. Instead, do that all at once
// as a consequence of the filterFinished signal right after the local scope.
auto marker = diveListNotifier.enterCommand();
// Apply filter for each dive divesDisplayed = 0;
for_each_dive (i, d) {
bool show = showDive(d); // Apply filter for each dive
filter_dive(d, show); for_each_dive (i, d) {
if (show) bool show = showDive(d);
divesDisplayed++; filter_dive(d, show);
if (show)
divesDisplayed++;
}
invalidateFilter();
// Tell the dive trip model to update the displayed-counts
DiveTripModelBase::instance()->filterFinished();
countsChanged();
} }
invalidateFilter();
// Tell the dive trip model to update the displayed-counts
DiveTripModelBase::instance()->filterFinished();
countsChanged();
emit filterFinished(); emit filterFinished();
#if !defined(SUBSURFACE_MOBILE) #if !defined(SUBSURFACE_MOBILE)