mirror of
https://github.com/subsurface/subsurface.git
synced 2025-02-19 22:16:15 +00:00
Code Cleanup: Move the Hide/Show ruler to an internal method
By moving the Hide/Show of the ruler to an internal method, we gain a bit of codecleanuperism by removing a lot of unnecessary calls to their dest and source drag-handlers. Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
parent
ef4705070f
commit
2a48170fd3
3 changed files with 10 additions and 11 deletions
|
@ -364,8 +364,6 @@ void ProfileWidget2::plotDives(QList<dive *> dives)
|
|||
s.beginGroup("TecDetails");
|
||||
const bool rulerVisible = s.value("rulergraph", false).toBool() && !printMode;
|
||||
rulerItem->setVisible(rulerVisible);
|
||||
rulerItem->sourceNode()->setVisible(rulerVisible);
|
||||
rulerItem->destNode()->setVisible(rulerVisible);
|
||||
|
||||
// No need to do this again if we are already showing the same dive
|
||||
// computer of the same dive, so we check the unique id of the dive
|
||||
|
@ -507,13 +505,9 @@ void ProfileWidget2::settingsChanged()
|
|||
|
||||
if (currentState == PROFILE) {
|
||||
rulerItem->setVisible(prefs.rulergraph);
|
||||
rulerItem->destNode()->setVisible(prefs.rulergraph);
|
||||
rulerItem->sourceNode()->setVisible(prefs.rulergraph);
|
||||
needReplot = true;
|
||||
} else {
|
||||
rulerItem->setVisible(false);
|
||||
rulerItem->destNode()->setVisible(false);
|
||||
rulerItem->sourceNode()->setVisible(false);
|
||||
}
|
||||
if (needReplot)
|
||||
replot();
|
||||
|
@ -617,8 +611,6 @@ void ProfileWidget2::setEmptyState()
|
|||
diveCeiling->setVisible(false);
|
||||
reportedCeiling->setVisible(false);
|
||||
rulerItem->setVisible(false);
|
||||
rulerItem->destNode()->setVisible(false);
|
||||
rulerItem->sourceNode()->setVisible(false);
|
||||
pn2GasItem->setVisible(false);
|
||||
po2GasItem->setVisible(false);
|
||||
pheGasItem->setVisible(false);
|
||||
|
@ -691,8 +683,6 @@ void ProfileWidget2::setProfileState()
|
|||
s.beginGroup("TecDetails");
|
||||
bool rulerVisible = s.value("rulergraph", false).toBool();
|
||||
rulerItem->setVisible(rulerVisible);
|
||||
rulerItem->destNode()->setVisible(rulerVisible);
|
||||
rulerItem->sourceNode()->setVisible(rulerVisible);
|
||||
}
|
||||
|
||||
extern struct ev_select *ev_namelist;
|
||||
|
|
|
@ -157,3 +157,12 @@ void RulerItem2::setAxis(DiveCartesianAxis *time, DiveCartesianAxis *depth)
|
|||
source->timeAxis = time;
|
||||
recalculate();
|
||||
}
|
||||
|
||||
void RulerItem2::setVisible(bool visible)
|
||||
{
|
||||
QGraphicsLineItem::setVisible(visible);
|
||||
if (source)
|
||||
source->setVisible(visible);
|
||||
if (dest)
|
||||
dest->setVisible(visible);
|
||||
}
|
||||
|
|
|
@ -40,7 +40,7 @@ public:
|
|||
RulerNodeItem2 *sourceNode() const;
|
||||
RulerNodeItem2 *destNode() const;
|
||||
void setAxis(DiveCartesianAxis *time, DiveCartesianAxis *depth);
|
||||
|
||||
void setVisible(bool visible);
|
||||
private:
|
||||
struct plot_info pInfo;
|
||||
QPointF startPoint, endPoint;
|
||||
|
|
Loading…
Add table
Reference in a new issue