mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Code Cleanup: Move the Hide/Show ruler to an internal method

Browse source 
By moving the Hide/Show of the ruler to an internal method, we gain a bit
of codecleanuperism by removing a lot of unnecessary calls to their dest
and source drag-handlers.

Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Tomaz Canabrava 2014-05-21 12:18:05 -03:00 • committed by Dirk Hohndel
parent ef4705070f
commit 2a48170fd3
3 changed files with 10 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

10
qt-ui/profile/profilewidget2.cpp
View file

@ -364,8 +364,6 @@ void ProfileWidget2::plotDives(QList<dive *> dives)
s.beginGroup("TecDetails"); s.beginGroup("TecDetails");
const bool rulerVisible = s.value("rulergraph", false).toBool() && !printMode; const bool rulerVisible = s.value("rulergraph", false).toBool() && !printMode;
rulerItem->setVisible(rulerVisible); rulerItem->setVisible(rulerVisible);
rulerItem->sourceNode()->setVisible(rulerVisible);
rulerItem->destNode()->setVisible(rulerVisible);
// No need to do this again if we are already showing the same dive // No need to do this again if we are already showing the same dive
// computer of the same dive, so we check the unique id of the dive // computer of the same dive, so we check the unique id of the dive
@ -507,13 +505,9 @@ void ProfileWidget2::settingsChanged()
if (currentState == PROFILE) { if (currentState == PROFILE) {
rulerItem->setVisible(prefs.rulergraph); rulerItem->setVisible(prefs.rulergraph);
rulerItem->destNode()->setVisible(prefs.rulergraph);
rulerItem->sourceNode()->setVisible(prefs.rulergraph);
needReplot = true; needReplot = true;
} else { } else {
rulerItem->setVisible(false); rulerItem->setVisible(false);
rulerItem->destNode()->setVisible(false);
rulerItem->sourceNode()->setVisible(false);
} }
if (needReplot) if (needReplot)
replot(); replot();
@ -617,8 +611,6 @@ void ProfileWidget2::setEmptyState()
diveCeiling->setVisible(false); diveCeiling->setVisible(false);
reportedCeiling->setVisible(false); reportedCeiling->setVisible(false);
rulerItem->setVisible(false); rulerItem->setVisible(false);
rulerItem->destNode()->setVisible(false);
rulerItem->sourceNode()->setVisible(false);
pn2GasItem->setVisible(false); pn2GasItem->setVisible(false);
po2GasItem->setVisible(false); po2GasItem->setVisible(false);
pheGasItem->setVisible(false); pheGasItem->setVisible(false);
@ -691,8 +683,6 @@ void ProfileWidget2::setProfileState()
s.beginGroup("TecDetails"); s.beginGroup("TecDetails");
bool rulerVisible = s.value("rulergraph", false).toBool(); bool rulerVisible = s.value("rulergraph", false).toBool();
rulerItem->setVisible(rulerVisible); rulerItem->setVisible(rulerVisible);
rulerItem->destNode()->setVisible(rulerVisible);
rulerItem->sourceNode()->setVisible(rulerVisible);
} }
extern struct ev_select *ev_namelist; extern struct ev_select *ev_namelist;

9
qt-ui/profile/ruleritem.cpp
View file

@ -157,3 +157,12 @@ void RulerItem2::setAxis(DiveCartesianAxis *time, DiveCartesianAxis *depth)
source->timeAxis = time; source->timeAxis = time;
recalculate(); recalculate();
} }
void RulerItem2::setVisible(bool visible)
{
QGraphicsLineItem::setVisible(visible);
if (source)
source->setVisible(visible);
if (dest)
dest->setVisible(visible);
}

2
qt-ui/profile/ruleritem.h
View file

@ -40,7 +40,7 @@ public:
RulerNodeItem2 *sourceNode() const; RulerNodeItem2 *sourceNode() const;
RulerNodeItem2 *destNode() const; RulerNodeItem2 *destNode() const;
void setAxis(DiveCartesianAxis *time, DiveCartesianAxis *depth); void setAxis(DiveCartesianAxis *time, DiveCartesianAxis *depth);
void setVisible(bool visible);
private: private:
struct plot_info pInfo; struct plot_info pInfo;
QPointF startPoint, endPoint; QPointF startPoint, endPoint;