mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

cleanup: make DiveListView slots private

Browse source 
It makes reasoning about code so much easier when one knows that
functions cannot be accessed from the outside. Therefore, make
a number of DiveListView slots private. Moreover, unslotize
functions that never were used in connect calls.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2020-04-26 18:57:51 +02:00 • committed by Dirk Hohndel
parent 5d49da5d6b
commit 2ad3696230
1 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
desktop-widgets/divelistview.h
View file

@ -28,19 +28,21 @@ public:
QList<dive_trip *> selectedTrips(); QList<dive_trip *> selectedTrips();
static QString lastUsedImageDir(); static QString lastUsedImageDir();
static void updateLastUsedImageDir(const QString &s); static void updateLastUsedImageDir(const QString &s);
void loadImages();
void loadWebImages();
signals: signals:
void divesSelected(); void divesSelected();
public public
slots: slots:
void toggleColumnVisibilityByIndex();
void reloadHeaderActions(); void reloadHeaderActions();
private
slots:
void toggleColumnVisibilityByIndex();
void sortIndicatorChanged(int index, Qt::SortOrder order); void sortIndicatorChanged(int index, Qt::SortOrder order);
void removeFromTrip(); void removeFromTrip();
void deleteDive(); void deleteDive();
void markDiveInvalid(); void markDiveInvalid();
void markDiveValid(); void markDiveValid();
void rowsInserted(const QModelIndex &parent, int start, int end) override;
void reset() override;
void mergeTripAbove(); void mergeTripAbove();
void mergeTripBelow(); void mergeTripBelow();
void newTripAbove(); void newTripAbove();
@ -50,12 +52,12 @@ slots:
void splitDives(); void splitDives();
void renumberDives(); void renumberDives();
void shiftTimes(); void shiftTimes();
void loadImages();
void loadWebImages();
void diveSelectionChanged(const QVector<QModelIndex> &indices); void diveSelectionChanged(const QVector<QModelIndex> &indices);
void currentDiveChanged(QModelIndex index); void currentDiveChanged(QModelIndex index);
void tripChanged(dive_trip *trip, TripField); void tripChanged(dive_trip *trip, TripField);
private: private:
void rowsInserted(const QModelIndex &parent, int start, int end) override;
void reset() override;
void setSelection(const QRect &rect, QItemSelectionModel::SelectionFlags flags) override; void setSelection(const QRect &rect, QItemSelectionModel::SelectionFlags flags) override;
void unselectDives(); void unselectDives();
void mouseReleaseEvent(QMouseEvent *event) override; void mouseReleaseEvent(QMouseEvent *event) override;