mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Start to use the QSettings ObjectWrapper

Browse source 
start of the QSettinsg Object Wrapper usage on the code
this first patch removes two macros that generated around
200 lines in runtime for something like a quarter of it
Basically, whenever we changed anything we called the
PreferencesDialog::settingsChanged and connected everythign
to that signal, now each setting has it's own changed signal
and we can call it directly.

The best thing about this approach is that we don't trigger
repaints for things that are not directly profile related. (
actually we still do, but the plan is to remove them in due time)

this commit breaks correct atualization of the profile (because
everything was connected to PreferencesDialog::settingsChanged)
and now I need to hunt a bit for the correct connections

Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Tomaz Canabrava 2016-01-25 15:54:23 -02:00 • committed by Dirk Hohndel
parent 5afda93b71
commit 2c5fad73e8
7 changed files with 91 additions and 89 deletions
Download patch file Download diff file Expand all files Collapse all files

17
desktop-widgets/mainwindow.h
View file

@ -147,23 +147,6 @@ slots:
void on_actionImportDiveLog_triggered();
/* TODO: Move those slots below to it's own class */
void on_profCalcAllTissues_triggered(bool triggered);
void on_profCalcCeiling_triggered(bool triggered);
void on_profDcCeiling_triggered(bool triggered);
void on_profEad_triggered(bool triggered);
void on_profIncrement3m_triggered(bool triggered);
void on_profMod_triggered(bool triggered);
void on_profNdl_tts_triggered(bool triggered);
void on_profPO2_triggered(bool triggered);
void on_profPhe_triggered(bool triggered);
void on_profPn2_triggered(bool triggered);
void on_profHR_triggered(bool triggered);
void on_profRuler_triggered(bool triggered);
void on_profSAC_triggered(bool triggered);
void on_profScaled_triggered(bool triggered);
void on_profTogglePicture_triggered(bool triggered);
void on_profTankbar_triggered(bool triggered);
void on_profTissues_triggered(bool triggered);
void on_actionExport_triggered();
void on_copy_triggered();
void on_paste_triggered();