mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Cleanup: unify selection signals

Browse source 
For historic reasons, there where three distinct signals concerning
dive-selection from the undo-machinery:
1) divesSelected: sent newly selected dives
2) currentDiveChanged: sent if the current dive changed
3) selectionChanged: sent at the end of a command if either the selection
   or the current dive changed

Since now the undo-commands do a full reset of the selection, merge these
three signals into a single signal.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2019-06-23 12:46:42 +02:00 • committed by bstoeger
parent 4716c82032
commit 2e230da361
7 changed files with 59 additions and 93 deletions
Download patch file Download diff file Expand all files Collapse all files

6
desktop-widgets/divelistview.cpp
View file

@ -448,7 +448,7 @@ void DiveListView::selectDives(const QList<int> &newDiveSelection)
scrollTo(idx);
}
// now that everything is up to date, update the widgets
emit diveListNotifier.selectionChanged();
emit divesSelected();
dontEmitDiveChangedSignal = false;
return;
}
@ -663,7 +663,7 @@ void DiveListView::selectionChanged(const QItemSelection &selected, const QItemS
}
}
if (!dontEmitDiveChangedSignal)
emit diveListNotifier.selectionChanged();
emit divesSelected();
// Display the new, processed, selection
QTreeView::selectionChanged(selectionModel()->selection(), newDeselected);
@ -1063,7 +1063,7 @@ void DiveListView::filterFinished()
// If there are no more selected dives, select the first visible dive
if (!selectionModel()->hasSelection())
selectFirstDive();
emit diveListNotifier.selectionChanged();
emit divesSelected();
}
QString DiveListView::lastUsedImageDir()