mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Undo: implement rudimentary support for undo of dive-splitting

Browse source 
For this, the core functionality of the split_dive() and
split_dive_at_time() functions were split out into new
split_dive_dont_insert() and split_dive_at_time_dont_insert(),
which do not add the new dives to the log. Thus, the undo-command
can take ownership of these dives, without having to remove them
first.

The split-dive functionality is temporarily made desktop-only
until mobile also supports "UndoObjects".

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2018-07-20 20:26:06 +02:00 • committed by Dirk Hohndel
parent 12df9faaa2
commit 302f6adb79
6 changed files with 145 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

10
desktop-widgets/divelistview.cpp
View file

@ -633,12 +633,16 @@ void DiveListView::splitDives()
int i;
struct dive *dive;
// Let's collect the dives to be split first, so that we don't catch newly inserted dives!
QVector<struct dive *> dives;
for_each_dive (i, dive) {
if (dive->selected)
split_dive(dive);
dives.append(dive);
}
for (struct dive *d: dives) {
UndoSplitDives *undoCommand = new UndoSplitDives(d, duration_t{-1});
MainWindow::instance()->undoStack->push(undoCommand);
}
MainWindow::instance()->refreshProfile();
MainWindow::instance()->refreshDisplay();
}
void DiveListView::renumberDives()