CICD: Update the AppImage Build to Use ubuntu 16.04.

Update the linux AppImage build to use ubuntu 16.04, and simplify it to
a single workflow running on a vanilla docker image.

This still uses the upload-artifact@v3 Action that will be EOL in
November 2024, because v4 relies on node 20 which has an unmet glibc
dependency in ubuntu 16.04. But this workflow can be updated to run on
ubuntu 18.04 by a simple search / replace and disabling some 16.04
specific PPAs.

@dirkh, @probonopd: I have moved this here from #4183 to be able to
review and discuss it without the noise of the workflow cleanup.

The workflow now also publishes the AppImage as an artifact on pull
request builds, available under Checks / Details / Summary.

Signed-off-by: Michael Keller <github@ike.ch>

scripts/docker/trusty-qt512/Dockerfile

@@ -1,85 +0,0 @@
-FROM ubuntu:14.04
-LABEL Description="Trusty with Qt 5.12 and Subsurface build deps"
-
-# right now (2019-11-27) the upstream image is broken
-# use workaround from https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/1854202
-ADD ubuntu-esm-infra-trusty /etc/apt/preferences.d/ubuntu-esm-infra-trusty
-
-# that's a lot of packages. Needed for the Qt installer, for QtWebKit
-# and for SmartTrak
-# the awkward start is because we need something newer than the default
-# compiler for QtWebKit and we need software-properties-common in order to
-# call add-apt-repositoty
-
-RUN apt-get -y update && apt-get install -y software-properties-common
-RUN add-apt-repository -y 'ppa:ubuntu-toolchain-r/test'
-RUN apt-get -y update && apt-get install -y \
-    gcc-7 g++-7 make git autoconf automake libtool pkg-config \
-    curl libdbus-1-3 libexpat1 libfontconfig1 libfreetype6 \
-    libexpat1-dev libgl1-mesa-dev libgl1-mesa-glx \
-    ruby gperf bison libx11-6 libx11-xcb1 libjpeg-dev libpng-dev \
-    libicu-dev libXcomposite-dev libXrender-dev libgstreamer-plugins-base1.0 \
-    libxml2-dev libxslt1-dev libzip-dev libsqlite3-dev libusb-1.0-0-dev \
-    libssl-dev libssh2-1-dev libcurl4-openssl-dev mesa-common-dev libqt5gui5 \
-    libxcb-xinerama0 libpulse-mainloop-glib0 libhyphen-dev libicu52 \
-    libglib2.0-dev mdbtools-dev libbluetooth-dev libmtp-dev
-
-# oddly this gets us too many gcc/g++ version (even though we explicitly
-# ask for gcc-7/g++-7
-RUN update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-7 10 && \
-    update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-7 10 && \
-    update-alternatives --install /usr/bin/cc cc /usr/bin/gcc 10 && \
-    update-alternatives --install /usr/bin/c++ c++ /usr/bin/g++ 10 && \
-    update-alternatives --set cc /usr/bin/gcc && \
-    update-alternatives --set c++ /usr/bin/g++
-
-# cmake in trusty is too old
-ADD cmake-3.13.2-Linux-x86_64.sh .
-RUN chmod a+x cmake-3.13.2-Linux-x86_64.sh && ./cmake-3.13.2-Linux-x86_64.sh --prefix=/usr --skip-license && rm -f cmake-3.13.2-Linux-x86_64.sh
-
-# deadsnale Python 3.6
-RUN add-apt-repository ppa:deadsnakes/ppa
-RUN apt-get update && sudo apt-get install -y python3.6
-
-# install Qt
-RUN curl "https://bootstrap.pypa.io/get-pip.py" -o "get-pip.py" && python3.6 get-pip.py
-RUN pip3 install aqtinstall
-RUN find /usr /home -name aqt -ls
-RUN /usr/local/bin/aqt install -O /usr/local/Qt 5.12.10 linux desktop
-RUN rm -rf /usr/local/Qt/Tools /usr/local/Qt/Docs /usr/local/Qt/Examples /usr/local/Qt/Maintenance* \
-           /usr/local/Qt/5.12.10/gcc_64/bin/qgltf /usr/local/Qt/5.12.10/gcc_64/bin/qdoc
-ENV QT_ROOT /usr/local/Qt/5.12.10/gcc_64
-ENV PATH="/usr/local/Qt/5.12.10/gcc_64/bin/:${PATH}"
-
-# now build and install QtWebKit
-RUN git clone -b 5.212 https://github.com/qt/qtwebkit
-RUN mkdir -p qtwebkit/WebKitBuild/Release
-RUN cd qtwebkit/WebKitBuild/Release && cmake -DPORT=Qt -DCMAKE_BUILD_TYPE=Release -DQt5_DIR=/usr/local/Qt/5.12.10/gcc_64/lib/cmake/Qt5 ../..
-RUN cd qtwebkit/WebKitBuild/Release && make -j4 && make install
-RUN rm -rf qtwebkit
-
-# finally, we need a new libdbus
-# RUN curl -O https://dbus.freedesktop.org/releases/dbus/dbus-1.12.16.tar.gz
-ADD dbus-1.12.16.tar.gz .
-RUN mkdir dbus-1.12.16/build && \
-    cd dbus-1.12.16/build && \
-    sed -inline 's/${CMAKE_INSTALL_FULL_LOCALSTATEDIR}\/lib\/dbus\/machine-id/\/var\/lib\/dbus\/machine-id/' ../cmake/CMakeLists.txt  && \
-    cmake ../cmake -DDBUS_INSTALL_SYSTEM_LIBS=1  && \
-    make -j4 install && \
-    ldconfig
-
-ADD OpenSSL_1_1_1i.tar.gz .
-RUN cd /openssl-OpenSSL_1_1_1i   && \
-    ./config --prefix=/usr/local/ssl --openssldir=/usr/local/ssl shared zlib && \
-    make -j4 && mkdir -p /ssllibs && cp *.so /ssllibs && cd / && rm -rf openssl-OpenSSL_1_1_1i
-
-# try to remove some of the packages we no longer need
-RUN apt-get remove -y libqt5core5a libqt5dbus5 libqt5gui5 ruby openssh-client
-
-# now build Subsurface once to populate the dependencies we don't get from
-# Ubuntu but that aren't really part of Subsurface (libgit, googlemaps)
-RUN git clone https://github.com/Subsurface/subsurface
-RUN bash -e -x ./subsurface/scripts/build.sh -desktop -create-appdir -build-with-webkit
-
-# remove the source, but keep the install-root
-RUN rm -rf subsurface libgit2 googlemaps

scripts/docker/trusty-qt512/getpackages.sh

@@ -1,5 +0,0 @@
-#!/bin/bash
-
-wget https://github.com/Kitware/CMake/releases/download/v3.13.2/cmake-3.13.2-Linux-x86_64.sh
-curl -O https://dbus.freedesktop.org/releases/dbus/dbus-1.12.16.tar.gz
-wget https://github.com/openssl/openssl/archive/OpenSSL_1_1_1i.tar.gz

scripts/docker/trusty-qt512/ubuntu-esm-infra-trusty

@@ -1,4 +0,0 @@
-# Written by ubuntu-advantage-tools
-Package: *
-Pin: release o=UbuntuESM, n=trusty
-Pin-Priority: never