mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2024-11-30 22:20:21 +00:00
Code Issues Projects Releases Packages Wiki Activity

git save: don't crash if the last dive isn't in a trip

Browse source 
The git save tries to generate a nice commit message based on the most
recent dive, but stupidly didn't check whether that dive was in a trip
or not, and unconditionally used the trip pointer to see if there was a
trip location.

Which works well enough if you always generate trips, but is an
unmitigated disaster otherwise.  Oops.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Linus Torvalds 2014-05-14 05:55:00 +09:00 committed by Dirk Hohndel
parent ed6a42f6f2
commit 3159a90b0a
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
save-git.c
View file

@ -850,7 +850,7 @@ static void create_commit_message(struct membuffer *msg)
nr = dive->number;
put_format(msg, "dive %d: %s", nr, location);
if (trip->location && *trip->location && strcmp(trip->location, location))
if (trip && trip->location && *trip->location && strcmp(trip->location, location))
put_format(msg, " (%s)", trip->location);
put_format(msg, "\n\n");
}