mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix uninitialized memory access in webservice download

Browse source 
In download_dialog_release_xml() we check if state->xmldata is non-NULL
and free it. But we don't set it to NULL anywhere, so if the user hits
cancel the variable is undefined.

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Dirk Hohndel 2013-02-25 13:38:18 -08:00
parent a635c30564
commit 31b2a6ffa8
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
webservice.c
View file

@ -218,7 +218,7 @@ void webservice_download_dialog(void)
const gchar *current_uid = subsurface_get_conf("webservice_uid");
GtkWidget *dialog, *vbox, *status, *info, *uid;
GtkWidget *frame_uid, *frame_status, *download, *image, *apply;
struct download_dialog_state *state = malloc(sizeof(struct download_dialog_state));
struct download_dialog_state *state = calloc(1, sizeof(struct download_dialog_state));
gboolean has_previous_uid = TRUE;
if (!current_uid) {