tests: add qPrefAnimations testcases

add test cases to secure struct preferences and qPrefAnimations work together

remove animation tests from testpreferences

Signed-off-by: Jan Iversen <jani@apache.org>

tests/CMakeLists.txt

@@ -98,6 +98,7 @@ TEST(TestRenumber testrenumber.cpp)
 TEST(TestGitStorage testgitstorage.cpp)
 TEST(TestPreferences testpreferences.cpp)
 TEST(TestQPrefDisplay testqPrefDisplay.cpp)
+TEST(TestQPrefAnimations testqPrefAnimations.cpp)
 TEST(TestPicture testpicture.cpp)
 TEST(TestMerge testmerge.cpp)
 TEST(TestTagList testtaglist.cpp)

tests/testpreferences.cpp

@@ -482,11 +482,6 @@ void TestPreferences::testPreferences()
 	TEST(language->dateFormatOverride(),true);
 	TEST(language->useSystemLanguage(), true);
 
-	pref->animation_settings->setAnimationSpeed(20);
-	TEST(pref->animation_settings->animationSpeed(), 20);
-	pref->animation_settings->setAnimationSpeed(30);
-	TEST(pref->animation_settings->animationSpeed(), 30);
-
 	auto location = pref->location_settings;
 	location->setTimeThreshold(10);
 	location->setDistanceThreshold(20);

tests/testqPrefAnimations.cpp

@@ -0,0 +1,81 @@
+// SPDX-License-Identifier: GPL-2.0
+#include "testqPrefAnimations.h"
+
+#include "core/settings/qPrefAnimations.h"
+#include "core/pref.h"
+#include "core/qthelper.h"
+
+#include <QDate>
+
+void TestQPrefAnimations::initTestCase()
+{
+	QCoreApplication::setOrganizationName("Subsurface");
+	QCoreApplication::setOrganizationDomain("subsurface.hohndel.org");
+	QCoreApplication::setApplicationName("SubsurfaceTestQPrefAnimations");
+}
+
+void TestQPrefAnimations::test_struct_get()
+{
+	// Test struct pref -> get func.
+
+	auto tst = qPrefAnimations::instance();
+
+	prefs.animation_speed = 17;
+
+	QCOMPARE(tst->animation_speed(), prefs.animation_speed);
+}
+
+void TestQPrefAnimations::test_set_struct()
+{
+	// Test set func -> struct pref
+
+	auto tst = qPrefAnimations::instance();
+
+	tst->set_animation_speed(27);
+
+	QCOMPARE(prefs.animation_speed, 27);
+}
+
+void TestQPrefAnimations::test_set_load_struct()
+{
+	// test set func -> load -> struct pref 
+
+	auto tst = qPrefAnimations::instance();
+
+	tst->set_animation_speed(33);
+
+	prefs.animation_speed = 17;
+
+	tst->load();
+	QCOMPARE(prefs.animation_speed, 33);
+}
+
+void TestQPrefAnimations::test_struct_disk()
+{
+	// test struct prefs -> disk
+
+	auto tst = qPrefAnimations::instance();
+
+	prefs.animation_speed = 27;
+
+	tst->sync();
+	prefs.animation_speed = 35;
+
+	tst->load();
+	QCOMPARE(prefs.animation_speed, 27);
+}
+
+void TestQPrefAnimations::test_multiple()
+{
+	// test multiple instances have the same information
+
+	prefs.animation_speed = 37;
+	auto tst_direct = new qPrefAnimations;
+
+	prefs.animation_speed = 25;
+	auto tst = qPrefAnimations::instance();
+
+	QCOMPARE(tst->animation_speed(), tst_direct->animation_speed());
+}
+
+QTEST_MAIN(TestQPrefAnimations)

tests/testqPrefAnimations.h

@@ -0,0 +1,19 @@
+// SPDX-License-Identifier: GPL-2.0
+#ifndef TESTQPREFANIMATIONS_H
+#define TESTQPREFANIMATIONS_H
+
+#include <QtTest>
+
+class TestQPrefAnimations : public QObject
+{
+	Q_OBJECT
+private slots:
+	void initTestCase();
+	void test_struct_get();
+	void test_set_struct();
+	void test_set_load_struct();
+	void test_struct_disk();
+	void test_multiple();
+};
+
+#endif // TESTQPREFANIMATIONS_H