mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

C++ Correctness and code cleanup.

Browse source 
Use const-reference where we can gain a bit of speed from that
and clear an else { if {}} by using else if.

Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Tomaz Canabrava 2014-07-29 13:06:30 -03:00 • committed by Dirk Hohndel
parent 8c8657f996
commit 357f5c19da
2 changed files with 5 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
qt-ui/groupedlineedit.cpp
View file

@ -106,7 +106,7 @@ void GroupedLineEdit::removeAllColors()
QStringList GroupedLineEdit::getBlockStringList() QStringList GroupedLineEdit::getBlockStringList()
{ {
QStringList retList; QStringList retList;
foreach (Private::Block block, d->blocks) foreach (const Private::Block &block, d->blocks)
retList.append(block.text); retList.append(block.text);
return retList; return retList;
} }

8
qt-ui/mainwindow.cpp
View file

@ -1025,19 +1025,17 @@ void MainWindow::removeRecentFile(QStringList failedFiles)
} }
} }
foreach (QString file, failedFiles) foreach (const QString &file, failedFiles)
files.removeAll(file); files.removeAll(file);
for (int c = 1; c <= 4; c++) { for (int c = 1; c <= 4; c++) {
QString key = QString("File_%1").arg(c); QString key = QString("File_%1").arg(c);
if (files.count() >= c) { if (files.count() >= c)
s.setValue(key, files.at(c - 1)); s.setValue(key, files.at(c - 1));
} else { else if (s.contains(key))
if (s.contains(key))
s.remove(key); s.remove(key);
} }
}
s.endGroup(); s.endGroup();
s.sync(); s.sync();