mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

cleanup: un-slotify QMLManager functions

Browse source 
Some slots in QMLManager were not called from the outside, some
only directly from C++-code. Make the former private and the latter
public member functions.

The idea here is to document which functions are actually called
from the outside and which are called from QML or connected to
signals.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2020-03-30 20:31:28 +02:00 • committed by Dirk Hohndel
parent d2f828fbf3
commit 38d70ba854
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
mobile-widgets/qmlmanager.h
View file

@ -152,6 +152,8 @@ public:
void setBtEnabled(bool value); void setBtEnabled(bool value);
void setShowNonDiveComputers(bool show); void setShowNonDiveComputers(bool show);
qreal lastDevicePixelRatio();
void setDevicePixelRatio(qreal dpr, QScreen *screen);
void setDiveListProcessing(bool value); void setDiveListProcessing(bool value);
@ -174,7 +176,6 @@ public slots:
void appInitialized(); void appInitialized();
void applicationStateChanged(Qt::ApplicationState state); void applicationStateChanged(Qt::ApplicationState state);
void saveCloudCredentials(const QString &email, const QString &password, const QString &pin); void saveCloudCredentials(const QString &email, const QString &password, const QString &pin);
void loadDivesWithValidCredentials();
void commitChanges(QString diveId, QString number, QString date, QString location, QString gps, void commitChanges(QString diveId, QString number, QString date, QString location, QString gps,
QString duration, QString depth, QString airtemp, QString duration, QString depth, QString airtemp,
QString watertemp, QString suit, QString buddy, QString watertemp, QString suit, QString buddy,
@ -222,12 +223,8 @@ public slots:
QString getGpsFromSiteName(const QString& siteName); QString getGpsFromSiteName(const QString& siteName);
QString getVersion() const; QString getVersion() const;
void deleteGpsFix(quint64 when); void deleteGpsFix(quint64 when);
void revertToNoCloudIfNeeded();
void consumeFinishedLoad();
void refreshDiveList(); void refreshDiveList();
void screenChanged(QScreen *screen); void screenChanged(QScreen *screen);
qreal lastDevicePixelRatio();
void setDevicePixelRatio(qreal dpr, QScreen *screen);
void appendTextToLog(const QString &newText); void appendTextToLog(const QString &newText);
void quit(); void quit();
void hasLocationSourceChanged(); void hasLocationSourceChanged();
@ -280,6 +277,9 @@ private:
QAction *undoAction; QAction *undoAction;
bool verifyCredentials(QString email, QString password, QString pin); bool verifyCredentials(QString email, QString password, QString pin);
void loadDivesWithValidCredentials();
void revertToNoCloudIfNeeded();
void consumeFinishedLoad();
#if defined(Q_OS_ANDROID) || defined(Q_OS_IOS) #if defined(Q_OS_ANDROID) || defined(Q_OS_IOS)
QString appLogFileName; QString appLogFileName;