mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Preferences tests: location updates & bug fix

Browse source 
Fixed loading the location preferences.

Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Tomaz Canabrava 2016-11-01 11:28:08 +01:00 • committed by Dirk Hohndel
parent 7f60951e75
commit 3966f3e7dd
3 changed files with 14 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
core/subsurface-qt/SettingsObjectWrapper.cpp
View file

@ -2229,13 +2229,6 @@ void SettingsObjectWrapper::load()
// Subsurface webservice id is stored outside of the groups // Subsurface webservice id is stored outside of the groups
GET_TXT("subsurface_webservice_uid", userid); GET_TXT("subsurface_webservice_uid", userid);
// but the related time / distance threshold (only used in the mobile app)
// are in their own group
s.beginGroup("locationService");
GET_INT("distance_threshold", distance_threshold);
GET_INT("time_threshold", time_threshold);
s.endGroup();
// GeoManagement // GeoManagement
s.beginGroup("geocoding"); s.beginGroup("geocoding");

2
core/subsurface-qt/SettingsObjectWrapper.h
View file

@ -668,7 +668,7 @@ signals:
void timeThresholdChanged(int value); void timeThresholdChanged(int value);
void distanceThresholdChanged(int value); void distanceThresholdChanged(int value);
private: private:
const QString group = QStringLiteral("locationService"); const QString group = QStringLiteral("LocationService");
}; };
class SettingsObjectWrapper : public QObject { class SettingsObjectWrapper : public QObject {

13
tests/testpreferences.cpp
View file

@ -537,6 +537,19 @@ void TestPreferences::testPreferences()
TEST(pref->animation_settings->animationSpeed(), 20); TEST(pref->animation_settings->animationSpeed(), 20);
pref->animation_settings->setAnimationSpeed(30); pref->animation_settings->setAnimationSpeed(30);
TEST(pref->animation_settings->animationSpeed(), 30); TEST(pref->animation_settings->animationSpeed(), 30);
auto location = pref->location_settings;
location->setTimeThreshold(10);
location->setDistanceThreshold(20);
TEST(location->timeThreshold(), 10);
TEST(location->distanceThreshold(), 20);
location->setTimeThreshold(30);
location->setDistanceThreshold(40);
TEST(location->timeThreshold(), 30);
TEST(location->distanceThreshold(), 40);
} }
QTEST_MAIN(TestPreferences) QTEST_MAIN(TestPreferences)