mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Cleanup: Don't clear WA_QuitOnClose attribute on dialogs

Browse source 
According to Qt's documentation, the application exits if all windows
with the WA_QuitOnClose attribute are closed. This attribute was cleared
for three dialogs. This seems not necessary because:
1) The application can't be closed as long as the modal dialog is shown.
2) The flag only concerns primary windows, which these are not.

See: http://doc.qt.io/qt-5/qguiapplication.html#quitOnLastWindowClosed-prop

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2018-06-15 20:22:07 +02:00 • committed by Dirk Hohndel
parent fed2a283b2
commit 3f012f4bdb
3 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
desktop-widgets/divecomputermanagementdialog.cpp
View file

@ -28,7 +28,6 @@ void DiveComputerManagementDialog::init()
DiveComputerManagementDialog *DiveComputerManagementDialog::instance() DiveComputerManagementDialog *DiveComputerManagementDialog::instance()
{ {
static DiveComputerManagementDialog *self = new DiveComputerManagementDialog(MainWindow::instance()); static DiveComputerManagementDialog *self = new DiveComputerManagementDialog(MainWindow::instance());
self->setAttribute(Qt::WA_QuitOnClose, false);
return self; return self;
} }

1
desktop-widgets/diveshareexportdialog.cpp
View file

@ -32,7 +32,6 @@ void DiveShareExportDialog::UIDFromBrowser()
DiveShareExportDialog *DiveShareExportDialog::instance() DiveShareExportDialog *DiveShareExportDialog::instance()
{ {
static DiveShareExportDialog *self = new DiveShareExportDialog(MainWindow::instance()); static DiveShareExportDialog *self = new DiveShareExportDialog(MainWindow::instance());
self->setAttribute(Qt::WA_QuitOnClose, false);
self->ui->txtResult->setHtml(""); self->ui->txtResult->setHtml("");
self->ui->buttonBox->setStandardButtons(QDialogButtonBox::Cancel); self->ui->buttonBox->setStandardButtons(QDialogButtonBox::Cancel);
return self; return self;

1
desktop-widgets/subsurfacewebservices.cpp
View file

@ -691,7 +691,6 @@ out:
DivelogsDeWebServices *DivelogsDeWebServices::instance() DivelogsDeWebServices *DivelogsDeWebServices::instance()
{ {
static DivelogsDeWebServices *self = new DivelogsDeWebServices(MainWindow::instance()); static DivelogsDeWebServices *self = new DivelogsDeWebServices(MainWindow::instance());
self->setAttribute(Qt::WA_QuitOnClose, false);
return self; return self;
} }