mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Remove the lastError from DeviceThreads

Browse source 
There is no reason for the DeviceThreads to keep a copy of the last
error around, so this removes that code.

Signed-off-by: Anton Lundin <glance@acc.umu.se>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Anton Lundin 2015-05-27 21:19:11 +02:00 • committed by Dirk Hohndel
parent f7be6daacc
commit 4124052b38
3 changed files with 13 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

26
configuredivecomputerthreads.cpp
View file

@ -1511,12 +1511,10 @@ void ReadSettingsThread::run()
dc_device_close(m_data->device);
if (!supported) {
lastError = tr("This feature is not yet available for the selected dive computer.");
emit error(lastError);
emit error(tr("This feature is not yet available for the selected dive computer."));
}
} else {
lastError = tr("Could not a establish connection to the dive computer.");
emit error(lastError);
emit error(tr("Could not a establish connection to the dive computer."));
}
}
@ -1573,12 +1571,10 @@ void WriteSettingsThread::run()
dc_device_close(m_data->device);
if (!supported) {
lastError = tr("This feature is not yet available for the selected dive computer.");
emit error(lastError);
emit error(tr("This feature is not yet available for the selected dive computer."));
}
} else {
lastError = tr("Could not a establish connection to the dive computer.");
emit error(lastError);
emit error(tr("Could not a establish connection to the dive computer."));
}
}
@ -1618,14 +1614,12 @@ void FirmwareUpdateThread::run()
dc_device_close(m_data->device);
if (!supported) {
lastError = tr("This feature is not yet available for the selected dive computer.");
emit error(lastError);
emit error(tr("This feature is not yet available for the selected dive computer."));
} else if (rc != DC_STATUS_SUCCESS) {
lastError = tr("Firmware update failed!");
emit error(tr("Firmware update failed!"));
}
} else {
lastError = tr("Could not a establish connection to the dive computer.");
emit error(lastError);
emit error(tr("Could not a establish connection to the dive computer."));
}
}
@ -1650,11 +1644,9 @@ void ResetSettingsThread::run()
dc_device_close(m_data->device);
if (!supported) {
lastError = tr("This feature is not yet available for the selected dive computer.");
emit error(lastError);
emit error(tr("This feature is not yet available for the selected dive computer."));
}
} else {
lastError = tr("Could not a establish connection to the dive computer.");
emit error(lastError);
emit error(tr("Could not a establish connection to the dive computer."));
}
}