mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-01 08:03:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

Correctly free the GSList in file_open

Browse source 
Passing a value that is known to be NULL to g_slist_free seems like the
wrong approach...

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Dirk Hohndel 2012-01-02 20:13:45 -08:00
parent eac816b9d8
commit 43530d397b
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gtk-gui.c
View file

@ -106,9 +106,9 @@ static void file_open(GtkWidget *w, gpointer data)
gtk_file_chooser_set_filter(GTK_FILE_CHOOSER(dialog), filter);
if (gtk_dialog_run(GTK_DIALOG(dialog)) == GTK_RESPONSE_ACCEPT) {
GSList *filenames;
GSList *filenames, *fn_glist;
char *filename;
filenames = gtk_file_chooser_get_filenames(GTK_FILE_CHOOSER(dialog));
filenames = fn_glist = gtk_file_chooser_get_filenames(GTK_FILE_CHOOSER(dialog));
GError *error = NULL;
while(filenames != NULL) {
@ -124,7 +124,7 @@ static void file_open(GtkWidget *w, gpointer data)
g_free(filename);
filenames = g_slist_next(filenames);
}
g_slist_free(filenames);
g_slist_free(fn_glist);
report_dives(FALSE);
}
gtk_widget_destroy(dialog);