mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

profile: remove TankItem's connection to the resize signal

Browse source 
Since the initial commit introducing TankItem, there was
a connection that replotted the item if the horizontal axis
sent the sizeChanged() signal. I never managed to create
this signal for the horizontal axis, only for the vertical
axes. Therefore remove this thing. If it turns out that
we need it after all, readd it in a more deterministic
way (i.e. call where it is needed).

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2020-12-23 12:26:12 +01:00 • committed by Dirk Hohndel
parent 27810f3217
commit 47d673bda3
2 changed files with 4 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
profile-widget/tankitem.cpp
View file

@ -7,8 +7,7 @@
static const qreal height = 3.0;
TankItem::TankItem(QObject *parent) :
QObject(parent),
TankItem::TankItem() :
plotEndTime(-1)
{
QColor red(PERSIANRED1);
@ -111,6 +110,4 @@ void TankItem::replot()
void TankItem::setHorizontalAxis(DiveCartesianAxis *horizontal)
{
hAxis = horizontal;
connect(hAxis, SIGNAL(sizeChanged()), this, SLOT(replot()));
replot();
}

10
profile-widget/tankitem.h
View file

@ -8,20 +8,16 @@
#include "profile-widget/divecartesianaxis.h"
#include "core/dive.h"
class TankItem : public QObject, public QGraphicsRectItem
class TankItem : public QGraphicsRectItem
{
Q_OBJECT
public:
explicit TankItem(QObject *parent = 0);
explicit TankItem();
void setHorizontalAxis(DiveCartesianAxis *horizontal);
void setData(struct plot_info *plotInfo, struct dive *d);
public slots:
void replot();
private:
void createBar(int startTime, int stopTime, struct gasmix gas);
void replot();
DiveCartesianAxis *hAxis;
int plotEndTime;
QBrush air, nitrox, oxygen, trimix;