mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Undo: remove ADD mode from main tab

Browse source 
Instead of letting the user edit the fields before adding a dive,
simply add an empty dive. Thus, the ADD mode of the main tab can
be removed.

Constructing a new dive with default-depth and making sure that
the dive is displayed correctly is very subtle. This all needs
to be detangled in due course.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2019-03-28 17:23:35 +01:00 • committed by Dirk Hohndel
parent 8287d86d2b
commit 4a3ffeba05
8 changed files with 98 additions and 174 deletions
Download patch file Download diff file Expand all files Collapse all files

5
desktop-widgets/tab-widgets/maintab.h
View file

@ -39,7 +39,6 @@ public:
enum EditMode {
NONE,
DIVE,
ADD,
MANUALLY_ADDED_DIVE,
IGNORE
};
@ -56,7 +55,6 @@ public:
void nextInputField(QKeyEvent *event);
signals:
void addDiveFinished();
void diveSiteChanged();
public
slots:
@ -69,7 +67,6 @@ slots:
void updateMode(struct dive *d);
void updateDateTime(struct dive *d);
void updateDiveSite(struct dive *d);
void updateDepthDuration();
void acceptChanges();
void rejectChanges();
void on_location_diveSiteSelected();
@ -90,7 +87,6 @@ slots:
void on_tagWidget_editingFinished();
void editCylinderWidget(const QModelIndex &index);
void editWeightWidget(const QModelIndex &index);
void addDiveStarted();
void addMessageAction(QAction *action);
void hideMessage();
void closeMessage();
@ -114,7 +110,6 @@ private:
bool lastSelectedDive;
int lastTabSelectedDive;
int lastTabSelectedDiveTrip;
void copyTagsToDisplayedDive();
dive_trip_t *currentTrip;
QList<TabBase*> extraWidgets;
};